Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

For finding changes in the push, use the list of commits and not before #2

Closed
jessitron opened this issue Mar 31, 2018 · 2 comments
Closed

Comments

@jessitron
Copy link
Contributor

jessitron commented Mar 31, 2018

We want to list the files changed in a push, for code reactions.

The before field on a push is "where did this ref last point?" which is different from the contents of the push.

The contents of the push are determined by the list of commits in the push. We need to take the earliest commit in that list (which seems to be, the last one) and then get its parent, and then compare the tip of the push (after or the first commit in the list, same one) to that.

This will make both new branches and force-pushes find the correct list of changed files.

Also, we should probably never use before. It doesn't mean what we think it does, except maybe for pushes to the default branch when force-push is disallowed.

@jessitron
Copy link
Contributor Author

dang it! wrong repo.

@jessitron
Copy link
Contributor Author

Issue moved to atomist/sdm#293

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant