Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For finding changes in the push, use the list of commits and not before #293

Closed
jessitron opened this issue Mar 31, 2018 · 0 comments
Closed
Assignees
Labels
bug Something isn't working changelog:fixed Add this issue or pull request to fixed changelog section
Milestone

Comments

@jessitron
Copy link
Contributor

jessitron commented Mar 31, 2018

We want to list the files changed in a push, for code reactions.

The before field on a push is "where did this ref last point?" which is different from the contents of the push.

The contents of the push are determined by the list of commits in the push. We need to take the earliest commit in that list (which seems to be, the last one) and then get its parent, and then compare the tip of the push (after or the first commit in the list, same one) to that.

This will make both new branches and force-pushes find the correct list of changed files.

Also, we should probably never use before. It doesn't mean what we think it does, except maybe for pushes to the default branch when force-push is disallowed.

see also: https://github.com/atomisthq/neo4j-ingester/issues/373

@johnsonr johnsonr added bug Something isn't working release:chockalog labels Apr 1, 2018
@cdupuis cdupuis added this to the 1.0.0 milestone Jul 12, 2018
@cdupuis cdupuis added enhancement New feature or request and removed bug Something isn't working labels Jul 12, 2018
@cdupuis cdupuis self-assigned this Sep 4, 2018
@cdupuis cdupuis added bug Something isn't working changelog:fixed Add this issue or pull request to fixed changelog section and removed enhancement New feature or request labels Sep 4, 2018
@cdupuis cdupuis closed this as completed Oct 3, 2018
atomist-bot added a commit that referenced this issue Oct 3, 2018
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working changelog:fixed Add this issue or pull request to fixed changelog section
Projects
None yet
Development

No branches or pull requests

3 participants