Fix mocha exiting with no test issue

The tests were not being run.  This ended up being due to importing
from the lib/client/index.ts in the Docker pack.

All internal imports from lib/client were removed.

Remove GraphQL files from Docker pack.

[changelog:fixed]

lib/pack/docker/build/DockerBuild.ts

@@ -14,6 +14,7 @@
  * limitations under the License.
  */
 
+import { GitProject } from "@atomist/automation-client/lib/project/git/GitProject";
 import { Goal, GoalDefinition } from "../../../api/goal/Goal";
 import { DefaultGoalNameGenerator } from "../../../api/goal/GoalNameGenerator";
 import {
@@ -24,7 +25,6 @@ import {
     mergeOptions,
 } from "../../../api/goal/GoalWithFulfillment";
 import { IndependentOfEnvironment } from "../../../api/goal/support/environment";
-import { GitProject } from "../../../client";
 import { DockerProgressReporter } from "./DockerProgressReporter";
 import { DefaultDockerImageNameCreator, DockerImageNameCreator, executeDockerBuild } from "./executeDockerBuild";
 

lib/pack/docker/build/executeDockerBuild.ts

@@ -14,6 +14,11 @@
  * limitations under the License.
  */
 
+import { HandlerContext } from "@atomist/automation-client/lib/HandlerContext";
+import { Success } from "@atomist/automation-client/lib/HandlerResult";
+import { GitProject } from "@atomist/automation-client/lib/project/git/GitProject";
+import { QueryNoCacheOptions } from "@atomist/automation-client/lib/spi/graph/GraphClient";
+import { executeAll } from "@atomist/automation-client/lib/util/pool";
 import * as fs from "fs-extra";
 import * as _ from "lodash";
 import * as os from "os";
@@ -27,7 +32,6 @@ import { ExecuteGoalResult } from "../../../api/goal/ExecuteGoalResult";
 import { ExecuteGoal } from "../../../api/goal/GoalInvocation";
 import { mergeOptions } from "../../../api/goal/GoalWithFulfillment";
 import { SdmGoalEvent } from "../../../api/goal/SdmGoalEvent";
-import { executeAll, GitProject, HandlerContext, QueryNoCacheOptions, Success } from "../../../client";
 import { readSdmVersion } from "../../../core/delivery/build/local/projectVersioner";
 import { toArray } from "../../../core/util/misc/array";
 import { postLinkImageWebhook } from "../../../core/util/webhook/ImageLink";

lib/pack/docker/parse/DockerFileParser.ts

@@ -14,19 +14,20 @@
  * limitations under the License.
  */
 
+import { File as ProjectFile } from "@atomist/automation-client/lib/project/File";
+import { FileParser } from "@atomist/automation-client/lib/tree/ast/FileParser";
+import { logger } from "@atomist/automation-client/lib/util/logger";
 import { TreeNode } from "@atomist/tree-path";
 import { DockerfileParser, From, Instruction, Label } from "dockerfile-ast";
 import { TextDocument } from "vscode-languageserver-textdocument";
 import { Position } from "vscode-languageserver-types/lib/umd/main";
-import { FileParser, logger, ProjectFile } from "../../../client";
 
 class DockerFileParserClass implements FileParser {
     public readonly rootName: "docker";
 
     public async toAst(f: ProjectFile): Promise<TreeNode> {
         try {
             const dockerfile = DockerfileParser.parse(await f.getContent());
-            // console.log(stringify(dockerfile));
             const doc = (dockerfile as any).document;
             const $children = dockerfile.getInstructions().map(i => instructionToTreeNode(i, doc));
             return {

package.json

@@ -34,7 +34,7 @@
     "@types/dateformat": "^3.0.0",
     "@types/find-up": "^2.1.1",
     "@types/flat": "0.0.28",
-    "@types/fs-extra": "^7.0.0",
+    "@types/fs-extra": "^9.0.1",
     "@types/js-yaml": "^3.12.2",
     "@types/json-stable-stringify": "^1.0.32",
     "@types/json-stringify-safe": "^5.0.0",
@@ -59,7 +59,7 @@
     "fast-glob": "3.1.1",
     "find-up": "^4.0.0",
     "flat": "^4.1.0",
-    "fs-extra": "^8.0.1",
+    "fs-extra": "^9.0.1",
     "globby": "^10.0.1",
     "js-yaml": "^3.13.1",
     "json-stable-stringify": "^1.0.1",