Rename newRepoWithCode to firstPush (#505)

atomist · Sep 2, 2018 · 68016ea · 68016ea
1 parent 60f4094
commit 68016ea
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -24,6 +24,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 -   **BREAKING** `ReviewerRegistration.action` renamed `inspect`.
 -   **BREAKING** Rename `ReviewGoal` -> \`CodeInspectionGoal. [#e30b6c1](https://github.com/atomist/sdm/commit/e30b6c15ffc3b35bf1fc09cd822f9a6fee1ee5a6)
 -   **BREAKING** Evaluate pushTest when selecting goal implementations. [#493](https://github.com/atomist/sdm/issues/493)
+-   **BREAKING** `addNewRepoWithCodeListener` renamed `addFirstPushListener`.
 -   Push tests for adding a goal implementation are not run. [#490](https://github.com/atomist/sdm/issues/490)
 -   Transform-testNaming. [#502](https://github.com/atomist/sdm/issues/502)
 -   **BREAKING** Remove unimplemented property observesOnly. [#501](https://github.com/atomist/sdm/issues/501)

diff --git a/src/api-helper/machine/ListenerRegistrationManagerSupport.ts b/src/api-helper/machine/ListenerRegistrationManagerSupport.ts
@@ -73,7 +73,7 @@ export class ListenerRegistrationManagerSupport implements ListenerRegistrationM
 
     public readonly pullRequestListeners: PullRequestListener[] = [];
 
-    public readonly newRepoWithCodeListeners: PushListener[] = [];
+    public readonly firstPushListeners: PushListener[] = [];
 
     public readonly channelLinkListeners: ChannelLinkListener[] = [];
 
@@ -144,8 +144,8 @@ export class ListenerRegistrationManagerSupport implements ListenerRegistrationM
         return this;
     }
 
-    public addNewRepoWithCodeListener(pls: PushListener): this {
-        this.newRepoWithCodeListeners.push(pls);
+    public addFirstPushListener(pls: PushListener): this {
+        this.firstPushListeners.push(pls);
         return this;
     }
 

diff --git a/src/api/listener/RepoCreationListener.ts b/src/api/listener/RepoCreationListener.ts
@@ -33,6 +33,6 @@ export interface RepoCreationListenerInvocation extends RepoListenerInvocation {
 /**
  * Respond to the creation of a new repo.
  * Note that it may not have code in it, so you may want to use
- * a PushListener! See SoftwareDeliveryMachine.addNewRepoWithCodeActions
+ * a PushListener! See SoftwareDeliveryMachine.addFirstPushListener
  */
 export type RepoCreationListener = SdmListener<RepoCreationListenerInvocation>;
diff --git a/src/api/machine/ListenerRegistrationManager.ts b/src/api/machine/ListenerRegistrationManager.ts
@@ -75,7 +75,7 @@ export interface ListenerRegistrationManager {
     addBuildListener(l: BuildListener);
 
     /**
-     * You probably mean to use addNewRepoWithCodeListener!
+     * You probably mean to use addFirstPushListener!
      * This responds to a repo creation, but there may be no
      * code in it. The invocation's addressChannels method with have no effect:
      * use the context if you want to send messages
@@ -100,7 +100,7 @@ export interface ListenerRegistrationManager {
      * @param {PushListener} pl
      * @return {this}
      */
-    addNewRepoWithCodeListener(pl: PushListener): this;
+    addFirstPushListener(pl: PushListener): this;
 
     addPullRequestListener(prl: PullRequestListener): this;
 
@@ -177,7 +177,7 @@ export interface ListenerRegistrationManager {
 
     pullRequestListeners: PullRequestListener[];
 
-    newRepoWithCodeListeners: PushListener[];
+    firstPushListeners: PushListener[];
 
     channelLinkListeners: ChannelLinkListener[];