Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a better workaround for not getting org token on custom events #279

Closed
jessitron opened this issue Mar 27, 2018 · 2 comments
Closed

Make a better workaround for not getting org token on custom events #279

jessitron opened this issue Mar 27, 2018 · 2 comments
Assignees
@cdupuis
Labels
changelog:fixed Add this issue or pull request to fixed changelog section enhancement New feature or request

Comments

@jessitron
Copy link
Contributor

jessitron commented Mar 27, 2018 •
edited
Loading

Currently it's grabbing the token from GITHUB_TOKEN as a workaround for automation-api#392, but that doesn't work for other configuration mechanisms.

Get it from the configuration; ask @ddgenome how to do this.

Check its scopes and output a nice error if it doesn't have repo scope. It'll need it for creating GH statuses.
@cdupuis
Copy link
Member

cdupuis commented Mar 29, 2018 •
edited
Loading

runningAutomationClient.configuration.token gets you the token.

@cdupuis
Copy link
Member

cdupuis commented May 5, 2018

We should now use the @Value annotation.

@cdupuis cdupuis added enhancement New feature or request changelog:fixed Add this issue or pull request to fixed changelog section labels Jul 12, 2018
@cdupuis cdupuis self-assigned this Jul 12, 2018
@cdupuis cdupuis closed this as completed Jul 12, 2018
atomist-bot added a commit that referenced this issue Jul 12, 2018
@atomist-bot
Changelog: #279 to fixed
819f9dc 
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdupuis cdupuis

Labels
changelog:fixed Add this issue or pull request to fixed changelog section enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdupuis @jessitron