Allow goals to receive implementations and listeners #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires more polish
[atomist:generated] [atomist:autofix=TypeScript header]
[atomist:generated] [atomist:autofix=TypeScript header]
[atomist:generated] [atomist:autofix=TypeScript header]
[atomist:generated] [atomist:autofix=tslint]
[atomist:generated] [atomist:autofix=TypeScript header]
[atomist:generated] [atomist:autofix=tslint]
cdupuis
added
changelog:added
cdupuis
changed the title
jessitron
reviewed
Sep 2, 2018
| const matchedNames = this.implementations.filter(m => | ||
| m.implementationName === goal.fulfillment.name && | ||
| m.goal.context === goal.externalKey); | ||
|
|
||
| const matchedGoalImplementations = []; |
There was a problem hiding this comment.
does this mean there are no more push tests on implementations? ... or that they aren't used?
There was a problem hiding this comment.
no, they are being used and evaluated when we SetOnGoalsOnPush. I added this here again last week which was a mistake.
jessitron
reviewed
Sep 2, 2018
src/api-helper/goal/storeGoals.ts
Outdated
| const {goalSet, goal, goalSetId, state, id, providerId, url} = parameters; | ||
| const fulfillment = parameters.fulfillment || {method: "other", name: "unspecified"}; | ||
| const { goalSet, goal, goalSetId, state, id, providerId, url } = parameters; | ||
| const fulfillment = parameters.fulfillment || { method: SdmGoalFulfillmentMethod.Other, name: "unkown" }; |
jessitron
reviewed
Sep 2, 2018
| @@ -268,6 +275,8 @@ export abstract class AbstractSoftwareDeliveryMachine<O extends SoftwareDelivery | |||
| goalSetters: Array<GoalSetter | GoalSetter[]>) { | |||
| super(); | |||
| // If we didn't get any goal setters don't register a mapping | |||
| registrableManager().register(this); | |||
There was a problem hiding this comment.
what does the global __registrable do?
johnsonr
approved these changes
Sep 2, 2018
| @@ -268,6 +275,8 @@ export abstract class AbstractSoftwareDeliveryMachine<O extends SoftwareDelivery | |||
| goalSetters: Array<GoalSetter | GoalSetter[]>) { | |||
| super(); | |||
| // If we didn't get any goal setters don't register a mapping | |||
| registrableManager().register(this); | |||
|
Pull request auto merged by Atomist.
[atomist:generated] [auto-merge:on-approve] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings infrastructure to create Typed Goals: goals that carry their own
ExecuteGoalimplementation. See Autofix for an example.The goal will find the SDM instances and register the goal implementations with it, so that from a user API all is left is to do:
This will allow us to provide a rich ecosystem of Goals for different types of delivery concerns without the requirement to change the core
SoftwareDeliveryMachineAPI.The main changes in this PR are backwards compatible and only additive. Only exception is the move of the well-known-goals to sdm.