-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow goals to receive implementations and listeners #504
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
e159fef
Allow goals to take implementations, side effects and callbacks
cdupuis a7ea850
Autofix: TypeScript header
atomist-bot 28f1b21
Minor update
cdupuis dadd8cd
Autofix: TypeScript header
atomist-bot 8c5d2ad
Fix registration lifecycle
cdupuis e231135
Autofix: TypeScript header
atomist-bot 32b80f4
Autofix: tslint
atomist-bot bf30f3c
Not quite yet
cdupuis c9e205a
Autofix: TypeScript header
atomist-bot 31ab913
Autofix: tslint
atomist-bot 5820ece
Clean out registrables that got registered
cdupuis 685c9cf
Allow to reset the registrable tracking for tests
cdupuis 9ed4636
Don't pass entire SDM; only the config
cdupuis a9f3c7c
Add well known goals to not break backwards compatibility
cdupuis 3ae7609
Remove well known goals
cdupuis 43d581b
Fix approvalRequired message not being used
cdupuis 4b36f70
Fix spelling error
cdupuis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
/* | ||
* Copyright © 2018 Atomist, Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import { | ||
logger, | ||
Success, | ||
} from "@atomist/automation-client"; | ||
import { Fingerprint } from "@atomist/automation-client/project/fingerprint/Fingerprint"; | ||
import { | ||
ExecuteGoal, | ||
GoalInvocation, | ||
} from "../../api/goal/GoalInvocation"; | ||
import { FingerprintListener } from "../../api/listener/FingerprintListener"; | ||
import { FingerprinterRegistration } from "../../api/registration/FingerprinterRegistration"; | ||
import { computeFingerprints } from "./computeFingerprints"; | ||
import { createPushImpactListenerInvocation } from "./createPushImpactListenerInvocation"; | ||
import { relevantCodeActions } from "./relevantCodeActions"; | ||
|
||
/** | ||
* Execute fingerprinting and send fingerprints to Atomist | ||
* @param {FingerprinterRegistration} fingerprinters | ||
* @param listeners listeners to fingerprints | ||
*/ | ||
export function executeFingerprinting(fingerprinters: FingerprinterRegistration[], | ||
listeners: FingerprintListener[]): ExecuteGoal { | ||
return async (goalInvocation: GoalInvocation) => { | ||
const { configuration, id, credentials, context } = goalInvocation; | ||
if (fingerprinters.length === 0) { | ||
return Success; | ||
} | ||
|
||
logger.debug("About to fingerprint %j using %d fingerprinters", id, fingerprinters.length); | ||
await configuration.sdm.projectLoader.doWithProject({ credentials, id, readOnly: true }, async project => { | ||
const cri = await createPushImpactListenerInvocation(goalInvocation, project); | ||
const relevantFingerprinters: FingerprinterRegistration[] = await relevantCodeActions(fingerprinters, cri); | ||
logger.info("Will invoke %d eligible fingerprinters of %d to %j", | ||
relevantFingerprinters.length, fingerprinters.length, cri.project.id); | ||
const fingerprints: Fingerprint[] = await computeFingerprints(cri, relevantFingerprinters.map(fp => fp.action)); | ||
await Promise.all(listeners.map(l => | ||
Promise.all(fingerprints.map(fingerprint => l({ | ||
id, | ||
context, | ||
credentials, | ||
addressChannels: cri.addressChannels, | ||
fingerprint, | ||
}))))); | ||
}); | ||
return Success; | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this mean there are no more push tests on implementations? ... or that they aren't used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, they are being used and evaluated when we SetOnGoalsOnPush. I added this here again last week which was a mistake.