Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session ID being used as Bearer in Authorization header #689

Closed
neilprosser opened this issue Mar 22, 2019 · 4 comments
Closed

Session ID being used as Bearer in Authorization header #689

neilprosser opened this issue Mar 22, 2019 · 4 comments
Assignees
@cdupuis
Labels
changelog:deprecated Add this issue or pull request to deprecated changelog section enhancement New feature or request

Comments

@neilprosser
Copy link

We've seen the SdmGoalById using the Session ID in the Authorization header. This was previously supported but we'd like to move to using API Keys instead.
@cdupuis
Copy link
Member

cdupuis commented Mar 22, 2019

The framework doesn’t allow that any more. Likely an outdated SDM somewhere.

@cdupuis cdupuis closed this as completed Mar 22, 2019
@cdupuis cdupuis reopened this Mar 22, 2019
@cdupuis
Copy link
Member

cdupuis commented Mar 22, 2019

Looks like some still uses the jwt.

https://github.com/atomist/sdm-core/blob/master/lib/handlers/events/delivery/goals/GoalAutomationEventListener.ts#L63

We should deprecate that property from Registration api.

@cdupuis cdupuis self-assigned this Mar 22, 2019
@cdupuis cdupuis added enhancement New feature or request changelog:deprecated Add this issue or pull request to deprecated changelog section labels Mar 22, 2019
@cdupuis cdupuis mentioned this issue Mar 22, 2019
Closed
@cdupuis
Copy link
Member

cdupuis commented Mar 22, 2019

Related issue atomist/automation-client#491 created

@atomist-bot
Copy link
Contributor

Related issue atomist/automation-client#491 closed by @cdupuis

[atomist:generated] [atomist:related-issue]

@cdupuis cdupuis closed this as completed Apr 2, 2019
atomist-bot added a commit that referenced this issue Apr 2, 2019
@atomist-bot
Changelog: #689 to deprecated
8752545 
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdupuis cdupuis

Labels
changelog:deprecated Add this issue or pull request to deprecated changelog section enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cdupuis @neilprosser @atomist-bot