Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no parameters issue with createJob #759

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Fix no parameters issue with createJob #759

merged 1 commit into from
Aug 13, 2019

Conversation

cdupuis
Copy link
Member

@cdupuis cdupuis commented Aug 13, 2019

No description provided.

@cdupuis cdupuis requested a review from ddgenome August 13, 2019 20:32
@cdupuis cdupuis added auto-merge:on-approve Auto-merge on review approvals changelog:fixed Add this issue or pull request to fixed changelog section auto-merge-method:merge Auto-merge with merge commit labels Aug 13, 2019
ddgenome
ddgenome approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@ddgenome ddgenome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/api-helper/misc/job/createJob.test.ts Outdated Show resolved Hide resolved
@ddgenome ddgenome removed the auto-merge:on-approve Auto-merge on review approvals label Aug 13, 2019
@cdupuis cdupuis added the auto-merge:on-approve Auto-merge on review approvals label Aug 13, 2019
@cdupuis cdupuis requested a review from ddgenome August 13, 2019 20:58
ddgenome
ddgenome approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@ddgenome ddgenome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@cdupuis cdupuis merged commit 854a5f4 into master Aug 13, 2019
@cdupuis
Copy link
Member Author

cdupuis commented Aug 13, 2019

Pull request auto merged by Atomist.

  • 1 approved review by @ddgenome
  • 2 successful checks

[atomist:generated] [auto-merge:on-approve]

@cdupuis cdupuis deleted the no-parameters-create-job branch August 13, 2019 21:02
cdupuis pushed a commit that referenced this pull request Aug 13, 2019
@atomist-bot
Changelog: #759 to fixed
4be9806 
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddgenome ddgenome ddgenome approved these changes

Assignees
No one assigned
Labels
auto-merge:on-approve Auto-merge on review approvals auto-merge-method:merge Auto-merge with merge commit changelog:fixed Add this issue or pull request to fixed changelog section
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdupuis @ddgenome