Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct interface for spawnCodeTransform #770

Merged
merged 1 commit into from
Sep 12, 2019
Merged

Correct interface for spawnCodeTransform #770

merged 1 commit into from
Sep 12, 2019

Conversation

ddgenome
Copy link
Contributor

Add SpawnLogInvocation interface for calling spawnLog when a
ProgressLog is available. Use this in spawnCodeTransform and use the
ProgressLog from the PushAwareParametersInvocation, if it is available
and one is not provided.

Clean up some tests.

Add SpawnLogInvocation interface for calling spawnLog when a
ProgressLog is available.  Use this in spawnCodeTransform and use the
ProgressLog from the PushAwareParametersInvocation, if it is available
and one is not provided.

Clean up some tests.
@ddgenome ddgenome added changelog:fixed Add this issue or pull request to fixed changelog section auto-merge:on-approve Auto-merge on review approvals auto-merge-method:merge Auto-merge with merge commit labels Sep 12, 2019
Copy link
Member

@cdupuis cdupuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdupuis cdupuis merged commit c2cb2e0 into master Sep 12, 2019
@cdupuis
Copy link
Member

cdupuis commented Sep 12, 2019

Pull request auto merged by Atomist.

  • 1 approved review by @cdupuis
  • 2 successful checks

[atomist:generated] [auto-merge:on-approve]

@cdupuis cdupuis deleted the autofix-log branch September 12, 2019 22:17
cdupuis pushed a commit that referenced this pull request Sep 12, 2019
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge:on-approve Auto-merge on review approvals auto-merge-method:merge Auto-merge with merge commit changelog:fixed Add this issue or pull request to fixed changelog section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants