Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update schema, remove SkillOutput #845

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Update schema, remove SkillOutput #845

merged 1 commit into from
Jan 25, 2021

Conversation

ddgenome
Copy link
Contributor

Update the schema shipped with the @atomist/sdm library. Remove
references to SkillOutput as it never materialized into a feature.

Update schema, remove SkillOutput
98b9dd9 
Update the schema shipped with the @atomist/sdm library. Remove
references to SkillOutput as it never materialized into a feature.
@ddgenome ddgenome requested a review from cdupuis January 25, 2021 16:47
@atomist atomist bot added auto-branch-delete:on-close Delete branch when pull request gets closed auto-merge-method:merge Auto-merge with merge commit auto-merge:on-approve Auto-merge on review approvals labels Jan 25, 2021
cdupuis
cdupuis approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@cdupuis cdupuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@atomist atomist bot merged commit fdfa1ec into main Jan 25, 2021
@atomist
Copy link
Contributor

atomist bot commented Jan 25, 2021

Pull request auto merged:

  • Branch protection rule for branch main passed
  • 1 approved review by @cdupuis
  • 3 successful checks

@atomist atomist bot deleted the remove-skill-output branch January 25, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdupuis cdupuis cdupuis approved these changes

Assignees
No one assigned
Labels
auto-branch-delete:on-close Delete branch when pull request gets closed auto-merge:on-approve Auto-merge on review approvals auto-merge-method:merge Auto-merge with merge commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddgenome @cdupuis