Optimize by registering labels to the instruction that follows the label #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pguyot
force-pushed
the
w34/optimize-by-offsetting-labels
branch
from
75a9f1b
to
000ce26
Compare
Signed-off-by: Paul Guyot <[email protected]>
pguyot
force-pushed
the
w34/optimize-by-offsetting-labels
branch
from
000ce26
to
a5a2195
Compare
bettio
requested changes
Oct 22, 2023
|
That's the point indeed. This PR consists in changing the address of labels at load time. Instead of having labels point to the label opcode, they are point to the opcode that follows. As a result, when executing a branch to a label, the label opcode is no longer executed. During execution, label opcodes are noop but require decoding. |
bettio
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It brings a significant speed improvement by avoiding processing label opcodes during execution.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later