Make big endian archs work #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettio
force-pushed
the
add-big-endian-support
branch
from
90957d0
to
aa2d52b
Compare
As a temporary fix just abort on an invalid iff. As a long term approach an error code should be returned. Signed-off-by: Davide Bettio <[email protected]>
bettio
force-pushed
the
add-big-endian-support
branch
2 times, most recently
from
edea613
to
47a7784
Compare
Use `__BYTE_ORDER__` == `__ORDER_BIG_ENDIAN__`, instead of `#ifdef`. Also add missing 64 bit macros. Signed-off-by: Davide Bettio <[email protected]>
Use s390x as big endian arch, since it is the easiest to use for testing purposes. Signed-off-by: Davide Bettio <[email protected]>
bettio
force-pushed
the
add-big-endian-support
branch
from
edaa3c8
to
c8d3f8b
Compare
fadushin
reviewed
Oct 23, 2023
fadushin
reviewed
Oct 23, 2023
fadushin
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #882 #103
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later