Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle python3-pip for Ubunt 20.04 and Update Documentation #86

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Handle python3-pip for Ubunt 20.04 and Update Documentation #86

wants to merge 3 commits into from

Conversation

jifox
Copy link

@jifox jifox commented Oct 3, 2020

Update Docunemtation - add example for docker_daemon_config:

@jifox
Copy link
Author

jifox commented Oct 3, 2020

Hi,
I needed to modify the vars/Debian.yml for my Ubuntu servers

cat /etc/lsb-release

DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=20.04
DISTRIB_CODENAME=focal
DISTRIB_DESCRIPTION="Ubuntu 20.04 LTS"

After that change, the swarm is installed correctly.

$ docker node ls
ID                            HOSTNAME            STATUS              AVAILABILITY        MANAGER STATUS      ENGINE VERSION
ri6yc1zmo3gzm2er2kgzdm8n0     swarm3              Ready               Active              Reachable           19.03.13
tk7dsge7egukhvcy6k7arhyf1 *   swarm1              Ready               Active              Leader              19.03.13
s3k6hnyw75hli4fm1sii0vx77     swarm2              Ready               Active              Reachable           19.03.13

@jifox jifox changed the title Update Docunemtation - add example for docker_daemon_config: Handle python3-pip for Ubunt 20.04 and Update Documentation Oct 3, 2020
@higidi
Copy link

higidi commented Oct 6, 2020

The usage of the ansible_python_version variable is suboptimal as it relies on the python version of the ansible manager host not on the managed remote host.

michaelfresco
michaelfresco reviewed Dec 20, 2020
View reviewed changes
Copy link

@michaelfresco michaelfresco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes script compatible with ubuntu 20.04.

vars/Debian.yml
@@ -1,10 +1,10 @@
---

python_pip_packages:
- python-pip
- "{% if ansible_python_version is version_compare('3.0.0', '<') %}python-pip{% else %}python3-pip{% endif %}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix. # This makes atosatto/ansible-dockerswarm compatible with ubuntu 20.04

@michaelfresco
Copy link

The usage of the ansible_python_version variable is suboptimal as it relies on the python version of the ansible manager host not on the managed remote host.

True. It'd be better to do with ansible facts. I'm making another PR.

This was referenced Mar 11, 2021
Closed
Closed
@Archarachne
Copy link

What is the status of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelfresco michaelfresco michaelfresco left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jifox @higidi @michaelfresco @Archarachne