forked from Shopify/dawn
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull in latest release 13.0.1 (#3292) #84
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix translation path (#3198) * Change product variant swatches' border color (#3204) * change color reference * remove character * increase to meet contrast ratio of 3 * Update swatch setting info text (#3205) * Update info text * remove duplication * add space * clean up language and association * add to second place * Update 9 translation files * Update 4 translation files * Update 6 translation files * Update 1 translation file --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * [Quick order list] Change 'plural' string to 'singular' when removing '1 item' on 'Remove all' confirmation (#3203) * Change the message when removing only one item from the QOL * Update 20 translation files * Update 6 translation files * Update 4 translation files --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * Fix drawer stylings (#3248) * Update 1 translation file (#3202) Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * Pull update from release branch and update version number and release notes (#3229) * Fix translation path (#3198) * Change product variant swatches' border color (#3204) * change color reference * remove character * increase to meet contrast ratio of 3 * Update swatch setting info text (#3205) * Update info text * remove duplication * add space * clean up language and association * add to second place * Update 9 translation files * Update 4 translation files * Update 6 translation files * Update 1 translation file --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * [Quick order list] Change 'plural' string to 'singular' when removing '1 item' on 'Remove all' confirmation (#3203) * Change the message when removing only one item from the QOL * Update 20 translation files * Update 6 translation files * Update 4 translation files --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * Update 1 translation file (#3202) Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * update version number and release notes --------- Co-authored-by: melissaperreault <[email protected]> Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> Co-authored-by: Eugene Kasimov <[email protected]> * Update 1 translation file (#3232) Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * Fix cart drawer header background and cart note summary spacing * more cart drawer touch ups * remove some of the unwanted changes --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> Co-authored-by: melissaperreault <[email protected]> Co-authored-by: Eugene Kasimov <[email protected]> * fix missing alt tags for collection images (#3262) * Update titles (#3265) * Condense country selector width when there are no currencies (#3269) * Recreate existing PR based on the right branch (#3274) * Fix product review alignment when product doesn't have medias (#3264) * Fix product review alignment when product doesn't have medias * Add the escape to match with branch target * Touch up scroll into view PDP (#3276) * Fix mobile behaviour for scroll into view * remove conditions * remove unused data attribute (#3277) * Remove sticky header on cart drawer to avoid overlap of content (#3279) * fix scrolling scenario on mobile (#3286) * Update 1 translation file (#3202) Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * Pull update from release branch and update version number and release notes (#3229) * Fix translation path (#3198) * Change product variant swatches' border color (#3204) * change color reference * remove character * increase to meet contrast ratio of 3 * Update swatch setting info text (#3205) * Update info text * remove duplication * add space * clean up language and association * add to second place * Update 9 translation files * Update 4 translation files * Update 6 translation files * Update 1 translation file --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * [Quick order list] Change 'plural' string to 'singular' when removing '1 item' on 'Remove all' confirmation (#3203) * Change the message when removing only one item from the QOL * Update 20 translation files * Update 6 translation files * Update 4 translation files --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * Update 1 translation file (#3202) Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * update version number and release notes --------- Co-authored-by: melissaperreault <[email protected]> Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> Co-authored-by: Eugene Kasimov <[email protected]> * Update 1 translation file (#3232) Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * Update README.md (#3128) * Update README.md * fix url formatting --------- Co-authored-by: Ludo <[email protected]> * Fix Theme Check offences (#3283) * Fix schema JSON formatting Co-authored-by: Abhishek Jani <[email protected]> * Add loading=eager attribute to gift card page img * Use liquid tag to combine successive liquid statements Co-authored-by: Abhishek Jani <[email protected]> * Remove snippet to avoid > 3 levels of nested snippets * Ignore AssetPreload theme check for font links --------- Co-authored-by: Abhishek Jani <[email protected]> * update release notes --------- Co-authored-by: melissaperreault <[email protected]> Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> Co-authored-by: Eugene Kasimov <[email protected]> Co-authored-by: Renan Souza <[email protected]> Co-authored-by: Abdulrahman Hamideh <[email protected]> Co-authored-by: Benjamin Sehl <[email protected]> Co-authored-by: Kai <[email protected]> Co-authored-by: Abhishek Jani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix translation path (Fix translation path Shopify/dawn#3198)
Change product variant swatches' border color (Change product variant swatches' border color Shopify/dawn#3204)
change color reference
remove character
increase to meet contrast ratio of 3
Update swatch setting info text (Update swatch setting info text Shopify/dawn#3205)
Update info text
remove duplication
add space
clean up language and association
add to second place
Update 9 translation files
Update 4 translation files
Update 6 translation files
Update 1 translation file
[Quick order list] Change 'plural' string to 'singular' when removing '1 item' on 'Remove all' confirmation ([Quick order list] Change 'plural' string to 'singular' when removing '1 item' on 'Remove all' confirmation Shopify/dawn#3203)
Change the message when removing only one item from the QOL
Update 20 translation files
Update 6 translation files
Update 4 translation files
Fix drawer stylings (Fix drawer stylings Shopify/dawn#3248)
Update 1 translation file (Update translations: merchant Shopify/dawn#3202)
Pull update from release branch and update version number and release notes (Pull update from release branch and update version number and release notes Shopify/dawn#3229)
Fix translation path (Fix translation path Shopify/dawn#3198)
Change product variant swatches' border color (Change product variant swatches' border color Shopify/dawn#3204)
change color reference
remove character
increase to meet contrast ratio of 3
Update swatch setting info text (Update swatch setting info text Shopify/dawn#3205)
Update info text
remove duplication
add space
clean up language and association
add to second place
Update 9 translation files
Update 4 translation files
Update 6 translation files
Update 1 translation file
[Quick order list] Change 'plural' string to 'singular' when removing '1 item' on 'Remove all' confirmation ([Quick order list] Change 'plural' string to 'singular' when removing '1 item' on 'Remove all' confirmation Shopify/dawn#3203)
Change the message when removing only one item from the QOL
Update 20 translation files
Update 6 translation files
Update 4 translation files
Update 1 translation file (Update translations: merchant Shopify/dawn#3202)
update version number and release notes
Update 1 translation file (Update translations: buyer Shopify/dawn#3232)
Fix cart drawer header background and cart note summary spacing
more cart drawer touch ups
remove some of the unwanted changes
fix missing alt tags for collection images (add missing alt texts for collection images (fix issue #3234) Shopify/dawn#3262)
Update titles (Update titles Shopify/dawn#3265)
Condense country selector width when there are no currencies (Condense country selector width when there are no currencies Shopify/dawn#3269)
Recreate existing PR based on the right branch (Recreate existing PR based on the right branch Shopify/dawn#3274)
Fix product review alignment when product doesn't have medias (Fix product review alignment when product doesn't have medias Shopify/dawn#3264)
Fix product review alignment when product doesn't have medias
Add the escape to match with branch target
Touch up scroll into view PDP (Touch up scroll into view PDP Shopify/dawn#3276)
Fix mobile behaviour for scroll into view
remove conditions
remove unused data attribute (Remove unused data attribute Shopify/dawn#3277)
Remove sticky header on cart drawer to avoid overlap of content (Remove sticky header on cart drawer to avoid overlap of content Shopify/dawn#3279)
fix scrolling scenario on mobile ([Product medias] Scroll left mobile fix Shopify/dawn#3286)
Update 1 translation file (Update translations: merchant Shopify/dawn#3202)
Pull update from release branch and update version number and release notes (Pull update from release branch and update version number and release notes Shopify/dawn#3229)
Fix translation path (Fix translation path Shopify/dawn#3198)
Change product variant swatches' border color (Change product variant swatches' border color Shopify/dawn#3204)
change color reference
remove character
increase to meet contrast ratio of 3
Update swatch setting info text (Update swatch setting info text Shopify/dawn#3205)
Update info text
remove duplication
add space
clean up language and association
add to second place
Update 9 translation files
Update 4 translation files
Update 6 translation files
Update 1 translation file
[Quick order list] Change 'plural' string to 'singular' when removing '1 item' on 'Remove all' confirmation ([Quick order list] Change 'plural' string to 'singular' when removing '1 item' on 'Remove all' confirmation Shopify/dawn#3203)
Change the message when removing only one item from the QOL
Update 20 translation files
Update 6 translation files
Update 4 translation files
Update 1 translation file (Update translations: merchant Shopify/dawn#3202)
update version number and release notes
Update 1 translation file (Update translations: buyer Shopify/dawn#3232)
Update README.md (Update README.md Shopify/dawn#3128)
Update README.md
fix url formatting
Fix Theme Check offences (Fix Theme Check offences Shopify/dawn#3283)
Fix schema JSON formatting
Add loading=eager attribute to gift card page img
Use liquid tag to combine successive liquid statements
Remove snippet to avoid > 3 levels of nested snippets
Ignore AssetPreload theme check for font links
PR Summary:
Why are these changes introduced?
Fixes #0.
What approach did you take?
Other considerations
Decision log
Visual impact on existing themes
Testing steps/scenarios
Demo links
Checklist