Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in latest release 13.0.1 (#3292) #84

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

atriantas
Copy link
Owner











  • Fix Theme Check offences (Fix Theme Check offences Shopify/dawn#3283)

  • Fix schema JSON formatting

  • Add loading=eager attribute to gift card page img

  • Use liquid tag to combine successive liquid statements

  • Remove snippet to avoid > 3 levels of nested snippets

  • Ignore AssetPreload theme check for font links


  • update release notes

PR Summary:

Why are these changes introduced?

Fixes #0.

What approach did you take?

Other considerations

Decision log

# Decision Alternatives Rationale Downsides
1

Visual impact on existing themes

Testing steps/scenarios

  • Step 1

Demo links

Checklist

* Fix translation path (#3198)

* Change product variant swatches' border color (#3204)

* change color reference

* remove character

* increase to meet contrast ratio of 3

* Update swatch setting info text (#3205)

* Update info text

* remove duplication

* add space

* clean up language and association

* add to second place

* Update 9 translation files

* Update 4 translation files

* Update 6 translation files

* Update 1 translation file

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* [Quick order list] Change 'plural' string to 'singular' when removing '1 item' on 'Remove all' confirmation (#3203)

* Change the message when removing only one item from the QOL

* Update 20 translation files

* Update 6 translation files

* Update 4 translation files

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Fix drawer stylings (#3248)

* Update 1 translation file (#3202)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Pull update from release branch and update version number and release notes (#3229)

* Fix translation path (#3198)

* Change product variant swatches' border color (#3204)

* change color reference

* remove character

* increase to meet contrast ratio of 3

* Update swatch setting info text (#3205)

* Update info text

* remove duplication

* add space

* clean up language and association

* add to second place

* Update 9 translation files

* Update 4 translation files

* Update 6 translation files

* Update 1 translation file

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* [Quick order list] Change 'plural' string to 'singular' when removing '1 item' on 'Remove all' confirmation (#3203)

* Change the message when removing only one item from the QOL

* Update 20 translation files

* Update 6 translation files

* Update 4 translation files

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update 1 translation file (#3202)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* update version number and release notes

---------

Co-authored-by: melissaperreault <[email protected]>
Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: Eugene Kasimov <[email protected]>

* Update 1 translation file (#3232)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Fix cart drawer header background and cart note summary spacing

* more cart drawer touch ups

* remove some of the unwanted changes

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: melissaperreault <[email protected]>
Co-authored-by: Eugene Kasimov <[email protected]>

* fix missing alt tags for collection images (#3262)

* Update titles (#3265)

* Condense country selector width when there are no currencies (#3269)

* Recreate existing PR based on the right branch (#3274)

* Fix product review alignment when product doesn't have medias (#3264)

* Fix product review alignment when product doesn't have medias

* Add the escape to match with branch target

* Touch up scroll into view PDP (#3276)

* Fix mobile behaviour for scroll into view

* remove conditions

* remove unused data attribute (#3277)

* Remove sticky header on cart drawer to avoid overlap of content (#3279)

* fix scrolling scenario on mobile (#3286)

* Update 1 translation file (#3202)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Pull update from release branch and update version number and release notes (#3229)

* Fix translation path (#3198)

* Change product variant swatches' border color (#3204)

* change color reference

* remove character

* increase to meet contrast ratio of 3

* Update swatch setting info text (#3205)

* Update info text

* remove duplication

* add space

* clean up language and association

* add to second place

* Update 9 translation files

* Update 4 translation files

* Update 6 translation files

* Update 1 translation file

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* [Quick order list] Change 'plural' string to 'singular' when removing '1 item' on 'Remove all' confirmation (#3203)

* Change the message when removing only one item from the QOL

* Update 20 translation files

* Update 6 translation files

* Update 4 translation files

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update 1 translation file (#3202)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* update version number and release notes

---------

Co-authored-by: melissaperreault <[email protected]>
Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: Eugene Kasimov <[email protected]>

* Update 1 translation file (#3232)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update README.md (#3128)

* Update README.md

* fix url formatting

---------

Co-authored-by: Ludo <[email protected]>

* Fix Theme Check offences (#3283)

* Fix schema JSON formatting

Co-authored-by: Abhishek Jani <[email protected]>

* Add loading=eager attribute to gift card page img

* Use liquid tag to combine successive liquid statements

Co-authored-by: Abhishek Jani <[email protected]>

* Remove snippet to avoid > 3 levels of nested snippets

* Ignore AssetPreload theme check for font links

---------

Co-authored-by: Abhishek Jani <[email protected]>

* update release notes

---------

Co-authored-by: melissaperreault <[email protected]>
Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: Eugene Kasimov <[email protected]>
Co-authored-by: Renan Souza <[email protected]>
Co-authored-by: Abdulrahman Hamideh <[email protected]>
Co-authored-by: Benjamin Sehl <[email protected]>
Co-authored-by: Kai <[email protected]>
Co-authored-by: Abhishek Jani <[email protected]>
@atriantas atriantas closed this Feb 23, 2024
@atriantas atriantas reopened this Feb 23, 2024
@atriantas atriantas merged commit fca464d into atriantas:staging Feb 23, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants