[Fixes #12] Mark outdated nature of Hardware Revision A #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modification explains the **Hardware Revision A** refers to potentially outdated chip variant no longer manufactured.
tmplt
requested changes
Apr 19, 2022
pac/README.md.revA.template
Outdated
| @@ -0,0 +1,9 @@ | |||
| # Peripheral Access Crate ${crate} for ${mcu} 32-bit MCU from Atmel/Microchip | |||
|
|
|||
| This PAC crate is related with **Hardware Revision A** that's highely likely outdated and no loger in production. | |||
There was a problem hiding this comment.
Suggested change
| This PAC crate is related with **Hardware Revision A** that's highely likely outdated and no loger in production. | |
| This PAC crate relates to **Hardware Revision A** that has been superseded by **Hardware Revision B** (refer to the `${crate}b` crate). The former is no longer in production. |
Expansion untested. A link to the B revision crate would be more apt.
There was a problem hiding this comment.
Change is coming with the link to crates.io. I'm not pushing regenerated PACs as I already have newer svd2rust and it's >33k files - so we do that once we do new PACs release.
tmplt
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates distinctive templates of
README.mds for PAC crates that are handled by theupdate.pyscript.Template files have been moved under
pac/directory to better reflect their current application.