Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added neovim rust-analyzer config file to gitignore #78

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

s7rul
Copy link
Contributor

@s7rul s7rul commented Apr 9, 2024

The rust-analyzer.json file is the default file for configuring rust-analyzer on a per project basis for rustaceanvim. Added it to the .gitignore as it is similar in function to the .vscode directory. Did not see it fit to add to the changelog as this does not change the hal in in any way and only has to do with not getting config files included in the repo.

@michalfita
Copy link
Collaborator

Please add entry to CHANGELOG.md for this to be merged, @s7rul . The change itself is harmless, so I don't mind including that entry in .gitignore.

@s7rul
Copy link
Contributor Author

s7rul commented Apr 9, 2024

Please add entry to CHANGELOG.md for this to be merged, @s7rul . The change itself is harmless, so I don't mind including that entry in .gitignore.

Added to changelog and squahed into one commit.

Copy link
Collaborator

@michalfita michalfita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in overall, w/suggestion.

CHANGELOG.md Outdated
@@ -7,6 +7,7 @@
- [Integration](https://crates.io/crates/mcan-core) with the [`mcan`](https://crates.io/crates/mcan) crate.
- Implementation of blocking::i2c::Transactional trait from [embedded-hal](https://crates.io/crates/embedded-hal) for TWI device.
- Support for `critical-section` feature, falling down to PAC optional dependency.
- Gitignore for `rust-analyzer.json` file used by the rustaceanvim Neovim plugin.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My preference would be "Add rust-analyzer.json used by rustaceanvin Neovim's plugin to .gitignore"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to "Add rust-analyzer.json used by Neovim plugin rustaceanvim to .gitignore."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants