-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added neovim rust-analyzer config file to gitignore #78
base: development
Are you sure you want to change the base?
Conversation
Please add entry to |
Added to changelog and squahed into one commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved in overall, w/suggestion.
CHANGELOG.md
Outdated
@@ -7,6 +7,7 @@ | |||
- [Integration](https://crates.io/crates/mcan-core) with the [`mcan`](https://crates.io/crates/mcan) crate. | |||
- Implementation of blocking::i2c::Transactional trait from [embedded-hal](https://crates.io/crates/embedded-hal) for TWI device. | |||
- Support for `critical-section` feature, falling down to PAC optional dependency. | |||
- Gitignore for `rust-analyzer.json` file used by the rustaceanvim Neovim plugin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My preference would be "Add rust-analyzer.json
used by rustaceanvin
Neovim's plugin to .gitignore
"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to "Add rust-analyzer.json
used by Neovim plugin rustaceanvim
to .gitignore
."
The rust-analyzer.json file is the default file for configuring rust-analyzer on a per project basis for rustaceanvim. Added it to the
.gitignore
as it is similar in function to the.vscode
directory. Did not see it fit to add to the changelog as this does not change the hal in in any way and only has to do with not getting config files included in the repo.