Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux support. #5

Merged
merged 1 commit into from
Sep 22, 2016
Merged

Linux support. #5

merged 1 commit into from
Sep 22, 2016

Conversation

@codecov-io
Copy link

Current coverage is 100% (diff: 100%)

Merging #5 into master will not change coverage

@@           master     #5   diff @@
====================================
  Files          19     19          
  Lines        1067   1072     +5   
  Methods         0      0          
  Messages        0      0          
  Branches        0      0          
====================================
+ Hits         1067   1072     +5   
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last update e41489b...238fdd2

@lorentey lorentey merged commit c309cb2 into attaswift:master Sep 22, 2016
@lorentey
Copy link
Collaborator

Awesome!

@lorentey
Copy link
Collaborator

I'm a little worried about how this shim seeds the Mersenne twister; I assume it won't just produce the same series after every startup, would it? arc4random plugs into the kernel random pool, so it provides relatively high quality entropy.

Also, it would be better to fill the buffer by generating four bytes at once (or eight if mt19937_64 is also available); there is no need to go byte by byte.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants