Skip to content
This repository has been archived by the owner on Aug 28, 2021. It is now read-only.

Auto-generate JS doc #1471

Closed
aboodman opened this issue May 10, 2016 · 12 comments
Closed

Auto-generate JS doc #1471

aboodman opened this issue May 10, 2016 · 12 comments
Assignees
Labels

Comments

@aboodman
Copy link
Contributor

aboodman commented May 10, 2016

In Go, we get Godoc for free. In JavaScript/Node I'm sure there are tools for this -- probably tons of them, all slightly broken and different.

@ghost ghost added the M OSS label May 20, 2016
@ghost ghost added the P0 label May 23, 2016
@ghost ghost changed the title Autogenerate API Doc for JavaScript and Go Autogenerate & Server API Doc for JavaScript and Go May 23, 2016
@ghost ghost assigned arv May 23, 2016
@mikegray
Copy link
Contributor

mikegray commented May 23, 2016

@arv
Copy link
Contributor

arv commented May 24, 2016

I've had some minor success with https://github.com/documentationjs/documentation. The main downside is that it only generates API docs for things with JSDoc comments. That means that we have to manually add comments to every single exported function/class and every single method 😿

@arv
Copy link
Contributor

arv commented Jun 9, 2016

Some status updates. I've landed some upstream changes at https://github.com/documentationjs/documentation. The big remaining task is to generate documentation for all exported functions/classes/vars.

@aboodman aboodman added P1 and removed P0 labels Jun 13, 2016
@mikegray
Copy link
Contributor

mikegray commented Aug 4, 2016

Once repo became public godoc works - https://godoc.org/github.com/attic-labs/noms. We still have work to do in order to make the content better - and of course we need a JS equivalent.

@aboodman aboodman changed the title Autogenerate & Server API Doc for JavaScript and Go Auto-generate JS doc Aug 4, 2016
@aboodman
Copy link
Contributor Author

aboodman commented Aug 4, 2016

I don't think we need a bug for "make content better" . That can just be
ongoing task. I'm going to retarget this bug to just JS.

On Wed, Aug 3, 2016 at 6:30 PM, Mike Gray [email protected] wrote:

Once repo became public godoc works -
https://godoc.org/github.com/attic-labs/noms. We still have work to do in
order to make the content better - and of course we need a JS equivalent.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1471 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAE6BNPureLC1LDi_AHYfN34FIMqCNSXks5qcUDNgaJpZM4Ibff5
.

@aboodman aboodman removed the P1 label Aug 4, 2016
@ghost ghost added P0 and removed M OSS labels Aug 6, 2016
@arv
Copy link
Contributor

arv commented Aug 23, 2016

Some update on the JS front. I've been contributing to documentation.js and there is one important feature missing. I have a PR for that: documentationjs/documentation#490. With that done we have "a complete" documentation.

We then need to setup a build that generates the HTML and deploy that somewhere.

After that I think we need to tweak the generated HTML quite a bit.

@arv
Copy link
Contributor

arv commented Aug 24, 2016

The documentation.js tool is "good enough" to move on.

For deployment I could set up another ec2 instance or maybe we should just store these in s3 (since these are just static files).

@cmasone-attic @zcstarr @mikegray What do you think?

@mikegray
Copy link
Contributor

Probably makes sense to take advantage of AWS CloudFront in front of S3 to serve these if they are all static.

@cmasone-attic
Copy link
Contributor

agreed

@zcstarr
Copy link
Contributor

zcstarr commented Aug 25, 2016

agreed as well , I think @mike is right s3 + aws cloudfront for smooth sailing and low maintence

arv added a commit to arv/noms that referenced this issue Aug 31, 2016
Turns out that documentationjs reads the babelrc file from js/noms
which leads to us having to do npm install in js/noms. Therefore
putting the dev deps in there and running the script from there
makes things cleaner.

It also allows doing:

  npm run build-docs

Towards attic-labs#1471
arv added a commit that referenced this issue Aug 31, 2016
Turns out that documentationjs reads the babelrc file from js/noms
which leads to us having to do npm install in js/noms. Therefore
putting the dev deps in there and running the script from there
makes things cleaner.

It also allows doing:

  npm run build-docs

Towards #1471
arv added a commit to arv/noms that referenced this issue Sep 9, 2016
This picks up my commits to discover all exported bindings as well as
sorting the docs alphabetically.

Towards attic-labs#1471
arv added a commit that referenced this issue Sep 9, 2016
This picks up my commits to discover all exported bindings as well as
sorting the docs alphabetically.

Towards #1471
@arv
Copy link
Contributor

arv commented Sep 13, 2016

We now automatically deploy to https://docs.noms.io/js/

I'm closing this. Lets open more specific bugs for things that needs to be improved.

@arv arv closed this as completed Sep 13, 2016
@ghost
Copy link

ghost commented Sep 13, 2016

So much awesome!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants