-
-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ultracompact Mode (search-only) #2357
Conversation
cebcc11
to
806bf90
Compare
sorry for being slow here, had a tonne on lately - haven't forgotten this and will get to reviewing it soon 🙏 |
Thanks, no worries @ellie ! |
No pressure, so if you're busy don't worry, but just to ping as I'm conscious that I'll struggle to get the necessary PR sequence right at some point, and thought I'd check in :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that, been a busy few weeks!
But yep looks great to me, thanks for the work!
I'm happy for a follow up if you'd like to address testing, but tbh I've let this languish for far too long and I'm happy to have it merged as-is (sorry again!) |
This reverts commit 4c2d820. It clashes with my code to choose the preview window position.
Thanks @ellie - sorry for the delay in getting back myself but appreciate you merging! Sounds good - will take a look at updating the other PR too. |
Not a problem, much faster than me 🤣 |
This reverts commit 4c2d820. It clashes with my code to choose the preview window position.
What does this PR do?
Adds an ultracompact mode only for search (interactive.rs) and not the inspector.
introduces a simplified inspector tab, with only previous-current-next commands as rows, in compact modeallows navigation through session history within the inspector (so compact inspector view is still useful)TODO
Checks