Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ultracompact Mode (search-only) #2357

Merged
merged 7 commits into from
Oct 7, 2024

Conversation

philtweir
Copy link
Contributor

@philtweir philtweir commented Aug 10, 2024

What does this PR do?

Adds an ultracompact mode only for search (interactive.rs) and not the inspector.

  • adds a config parameter to set a line height at which to switch to ultracompact
  • introduces a simplified inspector tab, with only previous-current-next commands as rows, in compact mode
  • allows navigation through session history within the inspector (so compact inspector view is still useful)
  • in ultracompact view, compresses indicator row into prompt, removes any non-command lines (except help if show_help is true)

TODO

  • additional tests, although keen for input on how best to do these
  • documentation (once configuration/semantics are aligned on)

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

@philtweir philtweir changed the title Ultracompact mode (search-only) Ultracompact Mode (search-only) Aug 10, 2024
@ellie
Copy link
Member

ellie commented Sep 9, 2024

sorry for being slow here, had a tonne on lately - haven't forgotten this and will get to reviewing it soon 🙏

@philtweir
Copy link
Contributor Author

Thanks, no worries @ellie !

@philtweir
Copy link
Contributor Author

philtweir commented Oct 7, 2024

No pressure, so if you're busy don't worry, but just to ping as I'm conscious that I'll struggle to get the necessary PR sequence right at some point, and thought I'd check in :D

Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that, been a busy few weeks!

But yep looks great to me, thanks for the work! :shipit:

@ellie ellie merged commit 4c2d820 into atuinsh:main Oct 7, 2024
19 checks passed
@ellie
Copy link
Member

ellie commented Oct 7, 2024

I'm happy for a follow up if you'd like to address testing, but tbh I've let this languish for far too long and I'm happy to have it merged as-is (sorry again!)

tessus added a commit to tessus/atuin that referenced this pull request Oct 7, 2024
This reverts commit 4c2d820.
It clashes with my code to choose the preview window position.
@philtweir
Copy link
Contributor Author

Thanks @ellie - sorry for the delay in getting back myself but appreciate you merging! Sounds good - will take a look at updating the other PR too.

@ellie
Copy link
Member

ellie commented Oct 20, 2024

Not a problem, much faster than me 🤣

tessus added a commit to tessus/atuin that referenced this pull request Nov 9, 2024
This reverts commit 4c2d820.
It clashes with my code to choose the preview window position.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants