Remove setting from site option when deleting plugin

[bookdude13]

Fixes #29.

One thing I noticed in this is that we are tracking plugin settings based on the plugin file path, not the slug. Could that cause issues for plugins which change their file location? Not sure how common that would be, but I feel like the slug makes more sense as an id?

[audrasjb]

Hi,
Looks great, thanks. Milestoning this to 0.2, scheduled this week :)

[pbiron]

One thing I noticed in this is that we are tracking plugin settings based on the plugin file path, not the slug. Could that cause issues for plugins which change their file location? Not sure how common that would be, but I feel like the slug makes more sense as an id?

Because that's how WP stores things in the active_plugins option and/or active_sitewide_plugins sitemeta.

It's possible to have more than 1 plugin in a single directory. any file with a plugin header directly within a directory will be treated as a separate plugin. For instance, create a directory, my-plugin that contains 2 files plugin1.php and plugin2.php, each of which has a plugin header and you'll see that they are both listed in the plugins list table.

Although, you shouldn't do that and I think it's against the guidelines for plugins in the .org repo.

The updater provides enough hooks that, theoretically, a premium plugin could be written that would allow each of those multiple plugins within the same directory to be updated separately.

I only know of one such "multiple plugins in the same directory" in the wide...and it's used on .org!!
See https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/plugins/handbook.

[pbiron]

BTW, this PR works great! Thanx for that @bookdude13!

[audrasjb]

Works great, thanks!

[bookdude13]

I only know of one such "multiple plugins in the same directory" in the wide...and it's used on .org!!
Haha, that's fantastic :)

Thanks for the info, and glad to help!