update tests and ci starts from 5.4 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.x #61 +/- ##
=======================================
Coverage ? 100.00%
Complexity ? 227
=======================================
Files ? 42
Lines ? 863
Branches ? 0
=======================================
Hits ? 863
Misses ? 0
Partials ? 0 Continue to review full report at Codecov.
|
|
I am merging this. But please look into the comments on 5.3 and 5.4 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@koriym Aura.Html is supporting from 5.3 onwards.
We cannot support 5.3 tests, yoast/polyfill only starts with 5.4 .
So without a CI we cannot support 5.3 and probably as a convenience we should update the composer.json php version to 5.4.0 so that only php versions that support will get installed. So no accidental damage. That may be considered as a BC break though.