Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link hrefs as well as script src for bundles #456

Closed
RichiCoder1 opened this issue Jan 5, 2017 · 5 comments
Closed

Update link hrefs as well as script src for bundles #456

RichiCoder1 opened this issue Jan 5, 2017 · 5 comments

Comments

@RichiCoder1
Copy link

Currently setIndexFileConfigTarget will updates all instances of src="" in the target index with the new bundle names. It would be great if it could also update href=s, as that would allow for things like <link rel="preload" href="~/scripts/app-bundle.js">. Though I haven't determined if there's any advantage to doing so yet.

@Alexander-Taran
Copy link
Contributor

Would you like to provide a pull request for it @RichiCoder1 ?

@Alexander-Taran
Copy link
Contributor

@3cp

async triageQuestion(id) =>{
 respondSameDay()
 let response = await getResponseFromOP( { timeout : fromYears(4) } )
 if(!response) {
    closeQuestion(id,randomReason())
 }
}

@3cp
Copy link
Member

3cp commented Jun 1, 2022

It's a valid request. We can make it happen by reducing code: skip matching of src=, so both src= and href= will work.

BTW, href="~/, I think the ~ does not work in web context.

@Alexander-Taran
Copy link
Contributor

@3cp yeah ~ is asp.net construct. Handled on server side.

@3cp
Copy link
Member

3cp commented Jun 1, 2022

I see, my latest commit ignored all leading path to the bundle name, only replacing the bundle name part. It should cover this use case.

Deleted few lines of code :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants