Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove readonly attribute on destination environment file #1032

Closed
wants to merge 1 commit into from
Closed

Remove readonly attribute on destination environment file #1032

wants to merge 1 commit into from

Conversation

lorond
Copy link
Contributor

@lorond lorond commented Feb 1, 2019

@CLAassistant
Copy link

CLAassistant commented Feb 1, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lorond lorond closed this Feb 1, 2019
@lorond
Copy link
Contributor Author

lorond commented Feb 1, 2019

need to revise, found bug

@avrahamcool
Copy link
Contributor

avrahamcool commented Feb 1, 2019 •
edited
Loading

what bug did you find?

keep in mind you need to manually delete the destination file that was created before your fix (because it already have the readonly flag).

@3cp
Copy link
Member

3cp commented Feb 1, 2019

If your problem is testing...

Currently tests only runs on nodejs v8, not v10.

Check .travis.yml for more details.

@lorond
Copy link
Contributor Author

lorond commented Feb 4, 2019

keep in mind you need to manually delete the destination file that was created before your fix (because it already have the readonly flag).

yep, that is why I simply want to remove readonly flag on destination file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lorond @CLAassistant @avrahamcool @3cp