Delete destination environment file before writting new

[lorond]

issue: #1031

[3cp]

@JeroenVinke I am not sure is this too much for 90% of users who do not use TFS? Is there any other option we have (like hiding this behind a custom menu)?

[avrahamcool]

why change the target file readonly flag?
if we are about to replace the whole file one line after that.
why don't just delete the file to make sure that a new one can be safely created?

I thought you wanted to change the readonly flag on the source file while copying it to the destination - so the target will always be without readonly.

on the same note:
is that the best way to handle environment settings?
by copying a file into the src right before build?
it's annoying to have a file in the src folder - who need's to not be checked-in into source control.
is there a better to way to handle this?

[JeroenVinke]

@lorond thanks for looking into this and creating the pr!

I also think that there are better ways to handle these environment settings. While we look into that, people who use tfs and run into this problem can use the fix that’s in this PR.

[3cp]

Probably need to add an entry here https://aurelia.io/docs/cli/recipes
The repo is here https://github.com/aurelia/documentation/blob/master/current/en-us/11.%20cli/7.%20recipes.md

@lorond would you like to help on the doc?

[lorond]

if we are about to replace the whole file one line after that.
why don't just delete the file to make sure that a new one can be safely created?

Thought, it would fail to delete readonly file, but it isn't. Changed it.

@lorond would you like to help on the doc?

Sure

[3cp]

@lorond LOL, just found out gulp.dest support changing mode out of box.

gulp.src('a.js')
.pipe(gulp.dest('out', {mode: parseInt('666', 8)}));

Or if you want more strict, parseInt('644', 8).

[lorond]

@huochunpeng not sure if it is a good solution as it changes mode after file copied, not before.
Eventually we need to overwrite artifacts of previous build. I guess, cleanup concept would be more appropriate, and as @avrahamcool noted preliminary file removal fits better.

[3cp]

I tested gulp.dest thing, it works very well when source file is read only, it ensures target file is not read only.

[lorond]

Yep, but consider it already readonly - someone run build without solution, fount fix, integrated it and run build again - build will fail. Removing readonly is kind of hack, removed entire file - normal cleanup (and could be implemented as separate task).

[avrahamcool]

is this PR going to be merged?

it's a beautiful solution for a common TFS problem.
it will not affect those who are not using TFS.
its far better than just pointing the user to a recipe in the docs.

[3cp]

@EisenbergEffect @JeroenVinke how do you think of bringing in this fix?

@lorond the new files to be touched are

skeleton/cli-bundler/aurelia_project/tasks__if_babel/transpile.js
skeleton/cli-bundler/aurelia_project/tasks__if_typescript/transpile.ts
skeleton/webpack/aurelia_project/tasks/environment.ext

[EisenbergEffect]

I'm fine with merging this if someone can resolve the conflicts.

[lorond]

I'll resolve them.
@huochunpeng thanks.

[3cp]

Also, please rewrite commit message to follow our Git Commit Guidelines. I guess this one is a "fix(all): ..." as the bug was in both cli-bundler and webpack based projects.

Thanks for the contribution!

[lorond]

done #1118