feat(scaffold-navigation): upgrade to bootstrap v4 and fontawesome v5 #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shahabganji could you help to have a look of test_docker_2? I cannot reproduce that protractor error locally. |
|
@3cp Sure I will |
3cp
force-pushed
the
bs4-scaffold-navigation
branch
3 times, most recently
from
9beb9d6
to
fbc6aeb
Compare
3cp
force-pushed
the
bs4-scaffold-navigation
branch
from
fbc6aeb
to
64467ff
Compare
3cp
commented
Mar 11, 2020
| @@ -56,7 +56,8 @@ const config = { | |||
| '--disable-renderer-backgrounding', | |||
| '--disable-device-discovery-notifications', | |||
| '--no-sandbox', | |||
| '--disable-dev-shm-usage' | |||
| '--disable-dev-shm-usage', | |||
| '--window-size=1024,768' | |||
There was a problem hiding this comment.
@shahabganji this fix did the job. The reason for element not interactable is that the protractor browser window size is too small.
Nobody knows why the default screen size is so small inside docker(or maybe vm). Explicit window size does the trick.
There was a problem hiding this comment.
When element is off screen, protractor says it's not interactable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been a long requested upgrade.