feat: Use Pinecone library list functionality

[bruvduroiu]

User description

Uses pinecone.Index.list to fetch vector ids, this has the benefit of using Pinecone's handling of Index host, especially when using the pinecone mock server

---

PR Type

enhancement

---

Description

• Replaced the manual pagination and request handling for retrieving vector IDs with the pinecone.Index.list method, simplifying the code and leveraging Pinecone's built-in functionality.
• Removed unnecessary parameters and headers setup for requests, as they are now handled by the Pinecone library.
• Streamlined the process of fetching metadata associated with vector IDs.

---

Changes walkthrough 📝

	Relevant files
Enhancement	pinecone.py Simplify vector ID retrieval using Pinecone library            semantic_router/index/pinecone.py Replaced custom pagination logic with pinecone.Index.list method. Removed manual request handling for vector listing. Simplified metadata fetching logic. +4/-34

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[github-actions]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Error Handling The new implementation using pinecone.Index.list should include error handling for potential exceptions or errors returned by the Pinecone API. Currently, there's no check for errors in the response which might lead to runtime exceptions if the API call fails.

[github-actions]

PR Code Suggestions ✨

Category	Suggestion	Score
Error handling	Add error handling for fetching metadata to improve robustness Add error handling for the fetch method inside the loop when metadata is included, to gracefully handle any exceptions or errors that might occur during the fetch operation. semantic_router/index/pinecone.py [375-379] -res_meta = ( - self.index.fetch(ids=[id], namespace=self.namespace) - if self.index - else {} -) +try: + res_meta = ( + self.index.fetch(ids=[id], namespace=self.namespace) + if self.index + else {} + ) +except Exception as e: + res_meta = {} + # Optionally log the exception or handle it accordingly Suggestion importance[1-10]: 9 Why: Adding error handling for the fetch operation is crucial for robustness, as it prevents the function from failing due to unexpected errors during metadata retrieval. This is a significant improvement in terms of reliability.	9
Possible bug	Check self.namespace is not None before using it to avoid runtime errors Ensure that self.namespace is not None before using it in the fetch method to prevent potential runtime errors. semantic_router/index/pinecone.py [375-379] -res_meta = ( - self.index.fetch(ids=[id], namespace=self.namespace) - if self.index - else {} -) +if self.namespace is not None: + res_meta = ( + self.index.fetch(ids=[id], namespace=self.namespace) + if self.index + else {} + ) +else: + res_meta = {} Suggestion importance[1-10]: 8 Why: Ensuring that self.namespace is not None before using it in the fetch method is a good practice to prevent runtime errors, enhancing the robustness of the code. This is a valuable improvement for error prevention.	8
	Improve the condition to break the loop to handle only empty lists Replace the check for empty ids with a more explicit condition to ensure the loop breaks only when ids is truly empty, avoiding potential issues with falsy values that are not empty lists. semantic_router/index/pinecone.py [369-370] -if not ids: +if ids == []: break Suggestion importance[1-10]: 7 Why: The suggestion improves the clarity of the condition by explicitly checking for an empty list, which can prevent potential issues with other falsy values. However, the impact is minor as the original condition would work correctly in most cases.	7
Enhancement	Use list comprehension for a more concise and efficient way to extend lists Use list comprehension to extend all_vector_ids which can be more concise and potentially more efficient. semantic_router/index/pinecone.py [368-371] -for ids in self.index.list(prefix=prefix): - if ids == []: - break - all_vector_ids.extend(ids) +all_vector_ids = [id for ids in self.index.list(prefix=prefix) for id in ids if ids] Suggestion importance[1-10]: 5 Why: While using list comprehension can make the code more concise, it changes the logic by removing the break condition, which may alter the intended behavior. The suggestion is not entirely appropriate given the context.	5

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.14%. Comparing base (5ba4f2a) to head (f0d8829).
Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
semantic_router/index/pinecone.py	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
+ Coverage   62.80%   63.14%   +0.33%     
==========================================
  Files          46       46              
  Lines        3444     3424      -20     
==========================================
- Hits         2163     2162       -1     
+ Misses       1281     1262      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.