Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON parser #17

Merged
merged 1 commit into from
Apr 1, 2021
Merged

JSON parser #17

merged 1 commit into from
Apr 1, 2021

Conversation

mrLSD
Copy link
Member

@mrLSD mrLSD commented Apr 1, 2021

  • added json parser (for eth-connector)
  • modified panic invocations as unreachable

@mrLSD mrLSD requested a review from artob as a code owner April 1, 2021 08:22
@mrLSD mrLSD self-assigned this Apr 1, 2021
@artob artob assigned artob and unassigned mrLSD Apr 1, 2021
@artob artob added the C-enhancement Category: New feature or request label Apr 1, 2021
artob
artob approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@artob artob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@artob artob merged commit e4bcf7e into master Apr 1, 2021
@artob artob deleted the json-parser branch April 1, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artob artob artob approved these changes

Assignees

@artob artob

Labels
C-enhancement Category: New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrLSD @artob