Fix(engine): update to latest SputnikVM #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birchmd
added
P-high
birchmd
commented
Oct 26, 2021
| impl StackExecutorParams { | ||
| fn new(gas_limit: u64) -> Self { | ||
| Self { | ||
| precompiles: Precompiles::new_istanbul(), |
There was a problem hiding this comment.
We'll need to update this to Berlin (and eventually London), but in the spirit of a minimal fix to the security advisory I chose to not do that update in this PR.
There was a problem hiding this comment.
We do have Berlin activated now. There is no way right now to do Berlin?
There was a problem hiding this comment.
Ah I see as per comment out code in another section.
Comment on lines
+273
to
+276
| fn make_executor<'a>( | ||
| &'a self, | ||
| engine: &'a Engine, | ||
| ) -> executor::StackExecutor<'static, 'a, executor::MemoryStackState<Engine>> { |
There was a problem hiding this comment.
Factoring this out from the Engine struct was needed now that executor::StackExecutor takes a reference to the precompiles map instead of the map itself. The explicit lifetimes are needed for it to compile.
birchmd
force-pushed
the
update-evm-dep
branch
from
f99176e
to
128ccd2
Compare
artob
pushed a commit
that referenced
this pull request
Nov 1, 2021
* Feat(engine): Public method for computing block hash at given height (#303) * Fix(precompiles): Always charge for gas in ecrecover (#305) * Fix(precompiles): Pad modexp input if it is too short (#306) * Feat(engine): Include address field in returned EVM logs (#299) * Fix(engine): Remove unnecessary eth-connector logic (#312) * Feat(benchmarks): update gas bounds after wasm cost reduction (#315) * Fix(engine): update to latest SputnikVM (#316) * Add logging of public of the signer (#319) Co-authored-by: Dmitry Strokov <[email protected]> Co-authored-by: Joshua J. Bouw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must update to the latest version of SputnikVM due to the recent security advisory.
Note: no changes to
Cargo.tomlwere needed because we use a git dependency on our own fork of the SputnikVM repo. I only needed to update the lock file viacargo update -p evmand then make some small code changes due to upstream API changes.