Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(xcc): Estimate EVM gas cost for xcc precompile #564

Merged
merged 3 commits into from
Aug 5, 2022
Merged

Feat(xcc): Estimate EVM gas cost for xcc precompile #564

merged 3 commits into from
Aug 5, 2022

Conversation

birchmd
Copy link
Member

@birchmd birchmd commented Aug 4, 2022

Addresses #560 (comment)

@birchmd birchmd added the C-enhancement Category: New feature or request label Aug 4, 2022
@birchmd birchmd requested a review from mfornet August 4, 2022 20:19
@birchmd birchmd mentioned this pull request Aug 4, 2022
Merged
joshuajbouw
joshuajbouw suggested changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@joshuajbouw joshuajbouw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite a bit more clever than I had anticipated.

Just needs a bit more documentation, and I'm pizza.

engine-precompiles/src/xcc.rs Outdated Show resolved Hide resolved
mfornet
mfornet approved these changes Aug 5, 2022
View reviewed changes
Copy link
Contributor

@mfornet mfornet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that the cost per byte (2) is almost negligible with respect to the cost base (115k).

engine-types/src/lib.rs Show resolved Hide resolved
@birchmd birchmd merged commit 5fa6694 into xcc Aug 5, 2022
@birchmd birchmd deleted the xcc-eth-gas-estimation branch August 5, 2022 11:55
birchmd added a commit that referenced this pull request Aug 10, 2022
@birchmd
Feat(xcc): Estimate EVM gas cost for xcc precompile (#564)
7e3c552
birchmd added a commit that referenced this pull request Aug 10, 2022
@birchmd
Feat(xcc): Estimate EVM gas cost for xcc precompile (#564)
dc6a30c
birchmd added a commit that referenced this pull request Aug 17, 2022
@birchmd
Feat(xcc): Estimate EVM gas cost for xcc precompile (#564)
b2fe243
birchmd added a commit that referenced this pull request Aug 18, 2022
@birchmd
Feat(xcc): Estimate EVM gas cost for xcc precompile (#564)
cc2b9b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuajbouw joshuajbouw joshuajbouw approved these changes

@mfornet mfornet mfornet approved these changes

Assignees
No one assigned
Labels
C-enhancement Category: New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@birchmd @joshuajbouw @mfornet