Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(xcc): User payment using wNEAR ERC-20 #572

Merged
merged 8 commits into from
Aug 16, 2022
Merged

Feat(xcc): User payment using wNEAR ERC-20 #572

merged 8 commits into from
Aug 16, 2022

Conversation

birchmd
Copy link
Member

@birchmd birchmd commented Aug 10, 2022

See #560 (comment) for context.

@birchmd birchmd requested a review from mfornet August 10, 2022 14:27
@birchmd birchmd mentioned this pull request Aug 10, 2022
Merged
@joshuajbouw
Copy link
Contributor

Yeah, this makes sense to me to charge in WNEAR since these are taking place on NEAR.

joshuajbouw
joshuajbouw suggested changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@joshuajbouw joshuajbouw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some things that I noticed. This is going to take me a week to go through the whole thing as a whole and try to poke holes into it I'm noticing :D.

engine-precompiles/src/lib.rs Show resolved Hide resolved
engine-precompiles/src/lib.rs Outdated Show resolved Hide resolved
engine-precompiles/src/xcc.rs Show resolved Hide resolved
engine-precompiles/src/xcc.rs Show resolved Hide resolved
engine-precompiles/src/xcc.rs Show resolved Hide resolved
engine-precompiles/src/xcc.rs Show resolved Hide resolved
engine/src/lib.rs Show resolved Hide resolved
etc/xcc-router/src/lib.rs Show resolved Hide resolved
mfornet
mfornet approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@mfornet mfornet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

engine/src/engine.rs Show resolved Hide resolved
@birchmd birchmd merged commit be232fd into xcc Aug 16, 2022
@birchmd birchmd deleted the xcc-wnear-payment branch August 16, 2022 21:16
birchmd added a commit that referenced this pull request Aug 17, 2022
@birchmd
Feat(xcc): User payment using wNEAR ERC-20 (#572)
77b3b4a
birchmd added a commit that referenced this pull request Aug 18, 2022
@birchmd
Feat(xcc): User payment using wNEAR ERC-20 (#572)
1d51597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuajbouw joshuajbouw joshuajbouw approved these changes

@mfornet mfornet mfornet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@birchmd @joshuajbouw @mfornet