Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reachable panic due to out-of-memory in modexp precompile #689

Merged
merged 36 commits into from
Mar 30, 2023
Merged

fix: reachable panic due to out-of-memory in modexp precompile #689

merged 36 commits into from
Mar 30, 2023

Commits on Feb 20, 2023

  1. chore: trigger capacity overflow and attempt to add with overflow… 

    … panics
    Ahmed Ali committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    3c98fa7 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. fix: tests and add extra edge cases tests

    ahmed committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    73a6d4b View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2023

  1. Merge branch 'develop' into fix/0x3bfc/audit-aur-07

    @0x3bfc
    0x3bfc authored Mar 2, 2023
    Configuration menu
    Copy the full SHA
    1a1bed7 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Merge branch 'develop' into fix/0x3bfc/audit-aur-07

    @0x3bfc
    0x3bfc authored Mar 9, 2023
    Configuration menu
    Copy the full SHA
    083b561 View commit details
    Browse the repository at this point in the history

  2. fix: clippy error

    ahmed committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    0fdc250 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Merge branch 'develop' into fix/0x3bfc/audit-aur-07

    @0x3bfc
    0x3bfc authored Mar 15, 2023
    Configuration menu
    Copy the full SHA
    642952a View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2023

  1. fix: update checks for out of memory and capacity errors

    ahmed committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    45c75cf View commit details
    Browse the repository at this point in the history

  2. fix: revert to old gas estimate

    ahmed committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    c0d7dd7 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. fix: minor test refactor

    ahmed committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    7a1b5a7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into fix/0x3bfc/audit-aur-07

    @0x3bfc
    0x3bfc authored Mar 21, 2023
    Configuration menu
    Copy the full SHA
    c7d2420 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. fix: oom but it fails with capacity overflow

    ahmed committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    cf97350 View commit details
    Browse the repository at this point in the history

  2. fix: add capacity error check

    ahmed committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    dca1d2c View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. Merge branch 'develop' into fix/0x3bfc/audit-aur-07

    @0x3bfc
    0x3bfc authored Mar 23, 2023
    Configuration menu
    Copy the full SHA
    9eb7aa6 View commit details
    Browse the repository at this point in the history

  2. fix: never returns errors from precompiles

    ahmed committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    0affec6 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2023

  1. chore: clean up and add more tests

    ahmed committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    eae6dd4 View commit details
    Browse the repository at this point in the history

  2. chore: more tests

    ahmed committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    202a90c View commit details
    Browse the repository at this point in the history

  3. refactor: zero modulus check

    ahmed committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    f9ba325 View commit details
    Browse the repository at this point in the history

  4. fix: remove unncessary check

    ahmed committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    3a30ff0 View commit details
    Browse the repository at this point in the history

  5. Update engine-precompiles/src/modexp.rs 

    Co-authored-by: Michael Birch <[email protected]>
    @0x3bfc @birchmd
    0x3bfc and birchmd authored Mar 24, 2023
    Configuration menu
    Copy the full SHA
    34c53d6 View commit details
    Browse the repository at this point in the history

  6. Update engine-precompiles/src/modexp.rs 

    Co-authored-by: Michael Birch <[email protected]>
    @0x3bfc @birchmd
    0x3bfc and birchmd authored Mar 24, 2023
    Configuration menu
    Copy the full SHA
    18cef85 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. Merge branch 'develop' into fix/0x3bfc/audit-aur-07

    @0x3bfc
    0x3bfc authored Mar 27, 2023
    Configuration menu
    Copy the full SHA
    92e51d7 View commit details
    Browse the repository at this point in the history

  2. fix: add helper function for test inputs

    ahmed committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    2ed42b6 View commit details
    Browse the repository at this point in the history

  3. fix: add integration tests

    ahmed committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    e4ffd83 View commit details
    Browse the repository at this point in the history

  4. Update engine-precompiles/src/modexp.rs 

    Co-authored-by: Michael Birch <[email protected]>
    @0x3bfc @birchmd
    0x3bfc and birchmd authored Mar 27, 2023
    Configuration menu
    Copy the full SHA
    074e3d8 View commit details
    Browse the repository at this point in the history

  5. Update engine-precompiles/src/modexp.rs 

    Co-authored-by: Michael Birch <[email protected]>
    @0x3bfc @birchmd
    0x3bfc and birchmd authored Mar 27, 2023
    Configuration menu
    Copy the full SHA
    5e64b90 View commit details
    Browse the repository at this point in the history

  6. Update engine-precompiles/src/modexp.rs 

    Co-authored-by: Michael Birch <[email protected]>
    @0x3bfc @birchmd
    0x3bfc and birchmd authored Mar 27, 2023
    Configuration menu
    Copy the full SHA
    08623e1 View commit details
    Browse the repository at this point in the history

  7. Update engine-precompiles/src/modexp.rs 

    Co-authored-by: Michael Birch <[email protected]>
    @0x3bfc @birchmd
    0x3bfc and birchmd authored Mar 27, 2023
    Configuration menu
    Copy the full SHA
    0651421 View commit details
    Browse the repository at this point in the history

  8. Update engine-precompiles/src/modexp.rs 

    Co-authored-by: Michael Birch <[email protected]>
    @0x3bfc @birchmd
    0x3bfc and birchmd authored Mar 27, 2023
    Configuration menu
    Copy the full SHA
    986d974 View commit details
    Browse the repository at this point in the history

  9. Update engine-precompiles/src/modexp.rs 

    Co-authored-by: Michael Birch <[email protected]>
    @0x3bfc @birchmd
    0x3bfc and birchmd authored Mar 27, 2023
    Configuration menu
    Copy the full SHA
    305505a View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. fix: StandardPrecompiles.sol compilation errors

    ahmed committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    27f0fe2 View commit details
    Browse the repository at this point in the history

  2. fix: revert to old implementation of StandardPrecompiles

    ahmed committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    61af4ca View commit details
    Browse the repository at this point in the history

  3. fix: integration tests

    ahmed committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    790d6b6 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into fix/0x3bfc/audit-aur-07

    @0x3bfc
    0x3bfc authored Mar 28, 2023
    Configuration menu
    Copy the full SHA
    f78acd3 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into fix/0x3bfc/audit-aur-07

    @0x3bfc
    0x3bfc authored Mar 28, 2023
    Configuration menu
    Copy the full SHA
    0f7fd7c View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. refactor: generate_modexp_test_input

    ahmed committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    b7116b8 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. fix: adding struct for test input

    ahmed committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    daa1af1 View commit details
    Browse the repository at this point in the history