fix: use shanghai config instead of london #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birchmd
approved these changes
Jun 8, 2023
vimpunk
force-pushed
the
fix/set-shanghai-config
branch
from
d7481d2
to
53175f5
Compare
aleksuss
reviewed
Jun 21, 2023
vimpunk
force-pushed
the
fix/set-shanghai-config
branch
2 times, most recently
from
edc0cae
to
612021f
Compare
aleksuss
force-pushed
the
fix/set-shanghai-config
branch
from
7781546
to
de80c4b
Compare
birchmd
approved these changes
Jun 21, 2023
aleksuss
approved these changes
Jun 22, 2023
joshuajbouw
approved these changes
Jun 22, 2023
|
Hold merging for now. |
joshuajbouw
pushed a commit
that referenced
this pull request
Jul 21, 2023
<!-- Thanks for submitting a pull request! Here are some helpful tips: * Always create branches on and target the `develop` branch. * Run all the tests locally and ensure that they are passing. * Run `make format` to ensure that the code is formatted. * Run `make check` to ensure that all checks passed successfully. * Small commits and contributions that attempt one single goal is preferable. * If the idea changes or adds anything functional which will affect users, an AIP discussion is required first on the Aurora forum: https://forum.aurora.dev/discussions/AIPs%20(Aurora%20Improvement%20Proposals). * Avoid breaking the public API (namely in engine/src/lib.rs) unless required. * If your PR is a WIP, ensure that you enable "draft" mode. * Your first PRs won't use the CI automatically unless a maintainer starts. If this is not your first PR, please do NOT abuse the CI resources. Checklist: - [ ] I have performed a self-review of my code - [ ] I have documented my code, particularly in the hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests to prove my fix or new feature is effective and works - [ ] Any dependent changes have been merged - [ ] The PR is targeting the `develop` branch and not `master` - [ ] I have pre-squashed my commits into a single commit and rebased. --> ## Description Engine is configured with Shanghai hardfork now. No other changes. ## Performance / NEAR gas cost considerations N/A <!-- Performance regressions are not ideal, though we welcome performance improvements. Any PR must be completely mindful of any gas cost increases. The CI will fail if the gas costs change at all. Do update these tests to accommodate for the new gas changes. It is good to explain this change, if necessary. --> ## Testing N/A <!-- Please describe the tests that you ran to verify your changes. --> ## How should this be reviewed N/A <!-- Include any recommendations of areas to be careful of to ensure that the reviewers use extra attention. --> ## Additional information N/A <!-- Include any additional information which you think should be in this PR, such as prior arts, future extensions, unresolved problems, or a TODO list which should be followed up. --> --------- Co-authored-by: Oleksandr Anyshchenko <[email protected]>
Merged
joshuajbouw
pushed a commit
that referenced
this pull request
Jul 21, 2023
<!-- Thanks for submitting a pull request! Here are some helpful tips: * Always create branches on and target the `develop` branch. * Run all the tests locally and ensure that they are passing. * Run `make format` to ensure that the code is formatted. * Run `make check` to ensure that all checks passed successfully. * Small commits and contributions that attempt one single goal is preferable. * If the idea changes or adds anything functional which will affect users, an AIP discussion is required first on the Aurora forum: https://forum.aurora.dev/discussions/AIPs%20(Aurora%20Improvement%20Proposals). * Avoid breaking the public API (namely in engine/src/lib.rs) unless required. * If your PR is a WIP, ensure that you enable "draft" mode. * Your first PRs won't use the CI automatically unless a maintainer starts. If this is not your first PR, please do NOT abuse the CI resources. Checklist: - [ ] I have performed a self-review of my code - [ ] I have documented my code, particularly in the hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests to prove my fix or new feature is effective and works - [ ] Any dependent changes have been merged - [ ] The PR is targeting the `develop` branch and not `master` - [ ] I have pre-squashed my commits into a single commit and rebased. --> ## Description Engine is configured with Shanghai hardfork now. No other changes. ## Performance / NEAR gas cost considerations N/A <!-- Performance regressions are not ideal, though we welcome performance improvements. Any PR must be completely mindful of any gas cost increases. The CI will fail if the gas costs change at all. Do update these tests to accommodate for the new gas changes. It is good to explain this change, if necessary. --> ## Testing N/A <!-- Please describe the tests that you ran to verify your changes. --> ## How should this be reviewed N/A <!-- Include any recommendations of areas to be careful of to ensure that the reviewers use extra attention. --> ## Additional information N/A <!-- Include any additional information which you think should be in this PR, such as prior arts, future extensions, unresolved problems, or a TODO list which should be followed up. --> --------- Co-authored-by: Oleksandr Anyshchenko <[email protected]>
joshuajbouw
pushed a commit
that referenced
this pull request
Jul 21, 2023
<!-- Thanks for submitting a pull request! Here are some helpful tips: * Always create branches on and target the `develop` branch. * Run all the tests locally and ensure that they are passing. * Run `make format` to ensure that the code is formatted. * Run `make check` to ensure that all checks passed successfully. * Small commits and contributions that attempt one single goal is preferable. * If the idea changes or adds anything functional which will affect users, an AIP discussion is required first on the Aurora forum: https://forum.aurora.dev/discussions/AIPs%20(Aurora%20Improvement%20Proposals). * Avoid breaking the public API (namely in engine/src/lib.rs) unless required. * If your PR is a WIP, ensure that you enable "draft" mode. * Your first PRs won't use the CI automatically unless a maintainer starts. If this is not your first PR, please do NOT abuse the CI resources. Checklist: - [ ] I have performed a self-review of my code - [ ] I have documented my code, particularly in the hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests to prove my fix or new feature is effective and works - [ ] Any dependent changes have been merged - [ ] The PR is targeting the `develop` branch and not `master` - [ ] I have pre-squashed my commits into a single commit and rebased. --> ## Description Engine is configured with Shanghai hardfork now. No other changes. ## Performance / NEAR gas cost considerations N/A <!-- Performance regressions are not ideal, though we welcome performance improvements. Any PR must be completely mindful of any gas cost increases. The CI will fail if the gas costs change at all. Do update these tests to accommodate for the new gas changes. It is good to explain this change, if necessary. --> ## Testing N/A <!-- Please describe the tests that you ran to verify your changes. --> ## How should this be reviewed N/A <!-- Include any recommendations of areas to be careful of to ensure that the reviewers use extra attention. --> ## Additional information N/A <!-- Include any additional information which you think should be in this PR, such as prior arts, future extensions, unresolved problems, or a TODO list which should be followed up. --> --------- Co-authored-by: Oleksandr Anyshchenko <[email protected]>
joshuajbouw
pushed a commit
that referenced
this pull request
Jul 21, 2023
<!-- Thanks for submitting a pull request! Here are some helpful tips: * Always create branches on and target the `develop` branch. * Run all the tests locally and ensure that they are passing. * Run `make format` to ensure that the code is formatted. * Run `make check` to ensure that all checks passed successfully. * Small commits and contributions that attempt one single goal is preferable. * If the idea changes or adds anything functional which will affect users, an AIP discussion is required first on the Aurora forum: https://forum.aurora.dev/discussions/AIPs%20(Aurora%20Improvement%20Proposals). * Avoid breaking the public API (namely in engine/src/lib.rs) unless required. * If your PR is a WIP, ensure that you enable "draft" mode. * Your first PRs won't use the CI automatically unless a maintainer starts. If this is not your first PR, please do NOT abuse the CI resources. Checklist: - [ ] I have performed a self-review of my code - [ ] I have documented my code, particularly in the hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests to prove my fix or new feature is effective and works - [ ] Any dependent changes have been merged - [ ] The PR is targeting the `develop` branch and not `master` - [ ] I have pre-squashed my commits into a single commit and rebased. --> ## Description Engine is configured with Shanghai hardfork now. No other changes. ## Performance / NEAR gas cost considerations N/A <!-- Performance regressions are not ideal, though we welcome performance improvements. Any PR must be completely mindful of any gas cost increases. The CI will fail if the gas costs change at all. Do update these tests to accommodate for the new gas changes. It is good to explain this change, if necessary. --> ## Testing N/A <!-- Please describe the tests that you ran to verify your changes. --> ## How should this be reviewed N/A <!-- Include any recommendations of areas to be careful of to ensure that the reviewers use extra attention. --> ## Additional information N/A <!-- Include any additional information which you think should be in this PR, such as prior arts, future extensions, unresolved problems, or a TODO list which should be followed up. --> --------- Co-authored-by: Oleksandr Anyshchenko <[email protected]>
joshuajbouw
added a commit
that referenced
this pull request
Jul 24, 2023
### Changes - Enabled Shanghai Ethereum hard fork support by @mandreyel. #773 - Added ability to pause and resume the core functionality of the contract by @Casuso. #779 - Added function call keys to be used with relayers by @aleksuss. #792 --------- Co-authored-by: mandreyel <[email protected]> Co-authored-by: Oleksandr Anyshchenko <[email protected]> Co-authored-by: Leandro Casuso Montero <[email protected]>
mrLSD
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Engine is configured with Shanghai hardfork now. No other changes.
Performance / NEAR gas cost considerations
N/A
Testing
N/A
How should this be reviewed
N/A
Additional information
N/A