Fix(modexp): use ibig implementation #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birchmd
added
C-enhancement
joshuajbouw
approved these changes
Jun 21, 2023
joshuajbouw
approved these changes
Jun 21, 2023
aleksuss
approved these changes
Jun 21, 2023
birchmd
added a commit
that referenced
this pull request
Jun 22, 2023
## Description Switch to using the `ibig` implementation for modexp. Its performance is better than current Aurora implementation in some (but not all) cases, and it is more battle-tested in terms of correctness.
joshuajbouw
added a commit
that referenced
this pull request
Jun 23, 2023
## 2.9.2 2023-06-22 ### Fixes - Use ibig implemenation of modexp by @birchmd. (#778) --------- Co-authored-by: Karim <[email protected]> Co-authored-by: Michael Birch <[email protected]> Co-authored-by: mandreyel <[email protected]> Co-authored-by: Oleksandr Anyshchenko <[email protected]> Co-authored-by: Alexey Lapitsky <[email protected]>
mrLSD
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch to using the
ibigimplementation for modexp. Its performance is better than current Aurora implementation in some (but not all) cases, and it is more battle-tested in terms of correctness.