fix: exceeded prepaid gas error in mirror_erc20_token #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birchmd
approved these changes
Sep 3, 2024
aleksuss
added a commit
that referenced
this pull request
Oct 10, 2024
## Description After some investigation, we realised that the problem was caused by a change in gas costs after switching to near protocol version 66. The change relates to the amount of gas used to load contract data, which was [changed](https://github.com/near/nearcore/blob/master/core/parameters/res/runtime_configs/66.yaml#L15) from 216750 to 1089295 Gas per byte. The change increases the amount of gas used in the `mirror_erc20_token_callback` to approximately to 1TGas. So, more than 5TGas is needed now. Thanks to @birchmd for his help with this investigation. ## Performance / NEAR gas cost considerations There are no changes in the performance. ## Testing #950 bumps `near-workspace` to 0.12, which contains updated `near-sandbox` 2.1.1. on which the error is reproduced. ## How should this be reviewed Check that the problem no longer reproduces after this commit is included in #950.
Merged
aleksuss
added a commit
that referenced
this pull request
Oct 10, 2024
### Additions - Added support of CANCUN hardfork by [@mrLSD]. ([#926]) - Added support of EIP-3607 by [@mrLSD]. ([#930]) - Removed restrictions from funding XCC sub-accounts by [@birchmd]. ([#931]) ### Changes - Made some EVM gas costs optimisations by [@mrLSD]. ([#934]) - Refactored the gas charge logic form EVM exit reasons by [@mrLSD]. ([#935]) - Updated some dependencies and rust-toolchain by [@mrLSD]. ([#936]) - Removed unused `bytes_to_hex` function by [@dwiekawki]. ([#942]) - Added building of actual version of the `near-sandbox` in the scheduled CI job by [@aleksuss] ([#950]) ### Fixes - Removed duplicated `test` task in the `README.md` by [@dwiekawki]. ([#943]) - Fixed some typos in the `README.md` and `Cargo.toml` by [@DemoYeti]. ([#945]) ([#946]) - Fixed exceeded prepaid gas error in the `mirror_erc20_token` transaction by [@aleksuss] ([#951]) - Modified `hardhat.config.js` to support contract verification by [@spilin] ([#958]) [#926]: #926 [#930]: #930 [#931]: #931 [#934]: #934 [#935]: #935 [#936]: #936 [#942]: #942 [#943]: #943 [#945]: #945 [#946]: #946 [#950]: #950 [#951]: #951 [#958]: #958 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Michael Birch <[email protected]> Co-authored-by: Evgeny Ukhanov <[email protected]> Co-authored-by: dwiekawki <[email protected]> Co-authored-by: dwiekawki <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: DemoYeti <[email protected]> Co-authored-by: spilin <[email protected]>
aleksuss
added a commit
that referenced
this pull request
Oct 10, 2024
### Additions - Added support of CANCUN hardfork by [@mrLSD]. ([#926]) - Added support of EIP-3607 by [@mrLSD]. ([#930]) - Removed restrictions from funding XCC sub-accounts by [@birchmd]. ([#931]) ### Changes - Made some EVM gas costs optimisations by [@mrLSD]. ([#934]) - Refactored the gas charge logic form EVM exit reasons by [@mrLSD]. ([#935]) - Updated some dependencies and rust-toolchain by [@mrLSD]. ([#936]) - Removed unused `bytes_to_hex` function by [@dwiekawki]. ([#942]) - Added building of actual version of the `near-sandbox` in the scheduled CI job by [@aleksuss] ([#950]) ### Fixes - Removed duplicated `test` task in the `README.md` by [@dwiekawki]. ([#943]) - Fixed some typos in the `README.md` and `Cargo.toml` by [@DemoYeti]. ([#945]) ([#946]) - Fixed exceeded prepaid gas error in the `mirror_erc20_token` transaction by [@aleksuss] ([#951]) - Modified `hardhat.config.js` to support contract verification by [@spilin] ([#958]) [#926]: #926 [#930]: #930 [#931]: #931 [#934]: #934 [#935]: #935 [#936]: #936 [#942]: #942 [#943]: #943 [#945]: #945 [#946]: #946 [#950]: #950 [#951]: #951 [#958]: #958 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Michael Birch <[email protected]> Co-authored-by: Evgeny Ukhanov <[email protected]> Co-authored-by: dwiekawki <[email protected]> Co-authored-by: dwiekawki <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: DemoYeti <[email protected]> Co-authored-by: spilin <[email protected]>
aleksuss
added a commit
that referenced
this pull request
Oct 10, 2024
### Additions - Added support of CANCUN hardfork by [@mrLSD]. ([#926]) - Added support of EIP-3607 by [@mrLSD]. ([#930]) - Removed restrictions from funding XCC sub-accounts by [@birchmd]. ([#931]) ### Changes - Made some EVM gas costs optimisations by [@mrLSD]. ([#934]) - Refactored the gas charge logic form EVM exit reasons by [@mrLSD]. ([#935]) - Updated some dependencies and rust-toolchain by [@mrLSD]. ([#936]) - Removed unused `bytes_to_hex` function by [@dwiekawki]. ([#942]) - Added building of actual version of the `near-sandbox` in the scheduled CI job by [@aleksuss] ([#950]) ### Fixes - Removed duplicated `test` task in the `README.md` by [@dwiekawki]. ([#943]) - Fixed some typos in the `README.md` and `Cargo.toml` by [@DemoYeti]. ([#945]) ([#946]) - Fixed exceeded prepaid gas error in the `mirror_erc20_token` transaction by [@aleksuss] ([#951]) - Modified `hardhat.config.js` to support contract verification by [@spilin] ([#958]) [#926]: #926 [#930]: #930 [#931]: #931 [#934]: #934 [#935]: #935 [#936]: #936 [#942]: #942 [#943]: #943 [#945]: #945 [#946]: #946 [#950]: #950 [#951]: #951 [#958]: #958 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Michael Birch <[email protected]> Co-authored-by: Evgeny Ukhanov <[email protected]> Co-authored-by: dwiekawki <[email protected]> Co-authored-by: dwiekawki <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: DemoYeti <[email protected]> Co-authored-by: spilin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After some investigation, we realised that the problem was caused by a change in gas costs after switching to near protocol version 66. The change relates to the amount of gas used to load contract data, which was changed from 216750 to 1089295 Gas per byte. The change increases the amount of gas used in the
mirror_erc20_token_callbackto approximately to 1TGas. So, more than 5TGas is needed now. Thanks to @birchmd for his help with this investigation.Performance / NEAR gas cost considerations
There are no changes in the performance.
Testing
#950 bumps
near-workspaceto 0.12, which contains updatednear-sandbox2.1.1. on which the error is reproduced.How should this be reviewed
Check that the problem no longer reproduces after this commit is included in #950.