Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility with stable #1

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Conversation

matklad
Copy link

@matklad matklad commented Jan 21, 2022

This removes the need for core::intrinsics by adding an implementation
of the relevant intrinsic. For wasm32-unknown-unknown target, this
should result in virtually identical generated code.

This removes the need for `core::intrinsics` by adding an implementation
of the relevant intrinsic. For wasm32-unknown-unknown target, this
should result in virtually identical generated code.
matklad added a commit to matklad/aurora-engine that referenced this pull request Jan 26, 2022
This pulls in near/wasmer#106 which should allow
us to upgrade the nightly version we use. An alternative would be to
pull in aurora-is-near/rjson#1, which should
(0.7 confidence) allow us to switch to stable.
matklad added a commit to matklad/aurora-engine that referenced this pull request Jan 26, 2022
This pulls in near/wasmer#106 which should allow
us to upgrade the nightly version we use. An alternative would be to
pull in aurora-is-near/rjson#1, which should
(0.7 confidence) allow us to switch to stable.
Copy link
Member

@birchmd birchmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mrLSD mrLSD merged commit a69799d into aurora-is-near:master Jan 26, 2022
@matklad
Copy link
Author

matklad commented Jan 26, 2022

Actually, I just realized that I wanted to ask @nagisa to take a look here as well -- they probably know a better way to fix this :)

@nagisa
Copy link

nagisa commented Jan 26, 2022

For the face value the changes seem reasonably good to me, but I'd probably be somewhat worried about the ability for this sort of implementation to correctly round the parsed fractional numbers. I haven't dug deeply enough into the code to understand why f64::parse is not being used, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants