min and max functions are not constexpr #244
Labels
⬇️ affects: code (interfaces)
Affects the way end users will interact with the library
📁 kind: enhancement
New feature or request
💪 effort: small
Comments
chiphogg
added
📁 kind: enhancement
chiphogg
added a commit
that referenced
this issue
Jun 23, 2024
These have been `constexpr` compatible since C++14. Mechanically, the way I did this was: 1. Find an overload that was not `constexpr`. 2. Make a test that requires it to be `constexpr` to pass (either tweaking an existing test, or making a new one). 3. Make sure the test fails. 4. Change the function until the test passes. The biggest challenge was that our default compiler wouldn't accept our lambda in a `constexpr` context. That feels like a bug, but in any case, we were able to work around it by making a manual function object with an explicitly `constexpr` call operator. Fixes #244.
chiphogg
added a commit
that referenced
this issue
Jun 24, 2024
These have been `constexpr` compatible since C++14. Mechanically, the way I did this was: 1. Find an overload that was not `constexpr`. 2. Make a test that requires it to be `constexpr` to pass (either tweaking an existing test, or making a new one). 3. Make sure the test fails. 4. Change the function until the test passes. The biggest challenge was that our default compiler wouldn't accept our lambda in a `constexpr` context. That feels like a bug, but in any case, we were able to work around it by making a manual function object with an explicitly `constexpr` call operator. Fixes #244.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
C++'s std::max and std::min have been
constexprsince C++14. It would be fantastic to have the Au implementations ofmaxandminsimilarlyconstexprso they could be used similar to those in the standard library.The text was updated successfully, but these errors were encountered: