Add forward declarations for individual units #314
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Individual
"au/units/*.hh"
files still pull in some decently heavymachinery. The sensible, scalable solution is to provide a
"au/units/*_fwd.hh"
file corresponding to each of them. Each"regular" units header will include its
_fwd.hh
header as the firstinclude (and we add a comment to that effect to prevent clang-format
from reordering them).
Happily, this enables us to write a somewhat meaningful test for the
forward declaraction machinery. We can now make a header file that
provides an interface with only the forward declarations. Then we call
that API inside of a test file.
Finally, this is worth updating the docs for:
fwd.hh
files.library I know of that provides it.
All of these changes are in separate commits for the convenience of the
reviewer: I recommend starting at the first, and using
n
andp
tonavigate them.
Fixes #232.