Migrate sample from GCM to FCM #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -123,17 +122,17 @@ private void createCameraSource(boolean autoFocus, boolean useFlash) { | |||
| .setFacing(CameraSource.CAMERA_FACING_BACK) | |||
| .setRequestedPreviewSize(1024, 600) | |||
| .setRequestedFps(15.0f) | |||
| .setFocusMode(autoFocus ? Camera.Parameters.FOCUS_MODE_CONTINUOUS_PICTURE : null); | |||
| .setFocusMode(true ? Camera.Parameters.FOCUS_MODE_CONTINUOUS_PICTURE : null); | |||
There was a problem hiding this comment.
Agree. Left this to linter auto-fix.
| @@ -63,21 +63,23 @@ | |||
| android:layout_width="match_parent" | |||
| android:layout_height="wrap_content" | |||
| android:layout_marginBottom="12dp" | |||
| android:textIsSelectable="true" | |||
There was a problem hiding this comment.
This only affects the sample app. It makes the text selectable so one can easily copy the device name / fcm token and use it on the firebase console to send test fcm notifications . No cosmetic change.
lbalmaceda
commented
Apr 5, 2019
| @@ -224,12 +224,12 @@ private String createJWT(@NonNull PrivateKey privateKey, | |||
| String headerAndPayload = base64UrlSafeEncode(gson.toJson(headers).getBytes()) | |||
| + "." + base64UrlSafeEncode(gson.toJson(claims).getBytes()); | |||
| final byte[] messageBytes = headerAndPayload.getBytes(); | |||
| final Signature signer = Signature.getInstance("SHA256withRSA", "BC"); | |||
| final Signature signer = Signature.getInstance("SHA256withRSA"); | |||
There was a problem hiding this comment.
Caused by: java.security.NoSuchAlgorithmException: The BC provider no longer provides an implementation for Signature.SHA256withRSA.
Please see https://android-developers.googleblog.com/2018/03/cryptography-changes-in-android-p.html for more details.
santiagoaguiar
approved these changes
Apr 5, 2019
hzalaz
approved these changes
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followed this migration guide.
GcmListenerService-> https://developers.google.com/cloud-messaging/android/android-migrate-gcmlistenerIDListenerService-> https://developers.google.com/cloud-messaging/android/android-migrate-iid-serviceapp/README.mdfile adding instructions on what values need to be set for this sample app to work. To sum up, thegoogle-services.jsonfile that can be downloaded from the Firebase console when opening the project configuration view, and the Guardian URL (same as before).Sample app won't run unless a valid
google-services.jsonfile is present on the app's module root.