-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support promise based tokenGetter in JwtHelperService #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 85.71% // Head: 85.71% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #748 +/- ##
=======================================
Coverage 85.71% 85.71%
=======================================
Files 2 2
Lines 7 7
=======================================
Hits 6 6
Misses 1 1 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ewanharris
approved these changes
Dec 13, 2022
This was referenced Dec 15, 2022
Merged
This was referenced Sep 10, 2024
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
tokenGetter is typed to be able to return a string or a promise. The interceptor can handle when tokenGetter returns a promise, but the JwtHelperService can not.
This PR updates the JwtHelperService in such a way that it can handle Promises.
Note that this does change the public API, but it's not to be considered a breaking change as we actualy fixing incorrect current behavior.
References
Closes #747
Checklist