Fixed Management API Grants class instantiation #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lbalmaceda - This is a very minor fix to a bug in the latest version that causes the management API not to work. Could you please review and release this as soon as possible? Thanks. |
lbalmaceda
reviewed
Jan 4, 2019
There was a problem hiding this comment.
@beck3905 nice catch! In order for this not to happen again, would you add some tests to that file as well please? You can copy-paste this file and add the missing methods/classes https://github.com/auth0/auth0-python/pull/164/files#diff-1e4900791205f36d990eff57682110bb
|
@lbalmaceda - Done! |
lbalmaceda
approved these changes
Jan 4, 2019
|
@lbalmaceda - Thank you. When will the next release with this fix be available on PyPi? |
lbalmaceda
changed the title
|
It's already there 😉 under |
|
Just saw it come through. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed typo by changing '.' to ','