Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-3175] Return token claims in TokenVerifier.verify() #273

Merged
merged 5 commits into from
Mar 9, 2022
Merged

[SDK-3175] Return token claims in TokenVerifier.verify() #273

merged 5 commits into from
Mar 9, 2022

Conversation

bisguzar
Copy link
Contributor

closes #272

@bisguzar bisguzar requested a review from a team as a code owner April 25, 2021 11:28
jtemporal
jtemporal previously approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@jtemporal jtemporal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PS.: I think the only thing missing here would be

  1. Updating the method docs to include a Return clause
  2. Add a unittest to check the payload returns correctly

@lbalmaceda lbalmaceda changed the title Return boolean in TokenVerifier.verify() Return token claims in TokenVerifier.verify() Aug 19, 2021
@bradydean bradydean mentioned this pull request Nov 27, 2021
Closed
4 tasks
@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️

@stale stale bot added the closed:stale Issue or PR has not seen activity recently label Mar 2, 2022
@stale stale bot removed the closed:stale Issue or PR has not seen activity recently label Mar 9, 2022
@evansims evansims changed the title Return token claims in TokenVerifier.verify() [SDK-3175] Return token claims in TokenVerifier.verify() Mar 9, 2022
evansims
evansims approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@evansims evansims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I've updated the PR with the changes suggested by @jtemporal

@evansims evansims merged commit 9e355df into auth0:master Mar 9, 2022
@adamjmcgrath adamjmcgrath added this to the 3.22.0 milestone Mar 22, 2022
@adamjmcgrath adamjmcgrath mentioned this pull request Mar 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evansims evansims evansims approved these changes

@jtemporal jtemporal jtemporal left review comments

Assignees
No one assigned
Labels
CH: Changed
Projects
None yet
Milestone
3.22.0
Development

Successfully merging this pull request may close these issues.

Returning boolean on token validator
4 participants
@bisguzar @evansims @jtemporal @adamjmcgrath