Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pw realm params optional #484

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Make pw realm params optional #484

merged 2 commits into from
Apr 13, 2023

Conversation

adamjmcgrath
Copy link
Contributor

Changes

Change scope, realm and audience arguments to keyword args, since these parameters are optional: http://auth0.com/oauth/grant-type/password-realm

References

Fixes #482

@adamjmcgrath adamjmcgrath added the review:small Small review label Mar 27, 2023
@adamjmcgrath adamjmcgrath marked this pull request as ready for review March 28, 2023 16:51
@adamjmcgrath adamjmcgrath requested a review from a team as a code owner March 28, 2023 16:51
@adamjmcgrath adamjmcgrath mentioned this pull request Apr 3, 2023
Closed
@adamjmcgrath adamjmcgrath merged commit 5c631cd into master Apr 13, 2023
@adamjmcgrath adamjmcgrath deleted the optional-pw-realm-args branch April 13, 2023 13:08
@adamjmcgrath adamjmcgrath mentioned this pull request Apr 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
review:small Small review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Outdated Readme.md
2 participants
@adamjmcgrath @stevehobbsdev