[v8] SignupAndLogin blows up if no response type is set #271

auth0 · Dec 16, 2016 · 513c1bb · 513c1bb
1 parent 96f85be
commit 513c1bb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/web-auth/index.js b/src/web-auth/index.js
@@ -259,6 +259,10 @@ WebAuth.prototype.login = function (options) {
     'audience'
   ]).with(options);
 
+  assert.check(params, { type: 'object', message: 'options parameter is not valid' }, {
+    responseType: { optional: true, type: 'string', message: 'responseType option is required' }
+  });
+
   params = this.transactionManager.process(params);
 
   windowHelper.redirect(this.client.buildAuthorizeUrl(params));

diff --git a/src/web-auth/redirect.js b/src/web-auth/redirect.js
@@ -36,6 +36,10 @@ Redirect.prototype.login = function (options, cb) {
 
   this.warn.warning('`webauth.redirect.login` will be soon deprecated, use `webauth.login` instead.');
 
+  assert.check(params, { type: 'object', message: 'options parameter is not valid' }, {
+    responseType: { optional: true, type: 'string', message: 'responseType option is required' }
+  });
+
   params = this.transactionManager.process(params);
 
   usernamePassword = new UsernamePassword(this.baseOptions);