Merge pull request #316 from auth0/random-fallback

Fallback to math.random if there is no crypto support

src/helper/random.js

@@ -1,13 +1,28 @@
 var windowHelper = require('./window');
 
+const randomFallback = {
+  getRandomValues: function(buffer) {
+    for(var a = 0; a < buffer.length; a++) {
+      buffer[a] = Math.floor(Math.random() * 255);
+    }
+
+    return buffer;
+  }
+}
+
 function randomString(length) {
-  var bytes = new Uint8Array(length);
+  if (typeof(Uint8Array) !== "undefined") {
+    var bytes = new Uint8Array(length);
+  } else {
+    var bytes = new Array(length);
+  }
+
   var result = [];
   var charset = '0123456789ABCDEFGHIJKLMNOPQRSTUVXYZabcdefghijklmnopqrstuvwxyz-._~';
 
   var cryptoObj = windowHelper.getWindow().crypto || windowHelper.getWindow().msCrypto;
-  if (!cryptoObj) {
-    return null;
+  if (!cryptoObj || typeof(Uint8Array) === "undefined") {
+    cryptoObj = randomFallback;
   }
 
   var random = cryptoObj.getRandomValues(bytes);

test/helper/object.test.js

@@ -420,7 +420,7 @@ describe('helpers', function () {
       });
     });
 
-    it('should not breack the string', function () {
+    it('should not break the string', function () {
       var object = "some random string";
 
       var newObject = objectHelper.toCamelCase(object);

test/helper/random.test.js

@@ -64,7 +64,8 @@ describe('helpers random', function () {
 
     it('return the a random string', function () {
       var string = random.randomString(10);
-      expect(string).to.be(null);
+      expect(string).to.not.be(null);
+      expect(string).to.be.a('string');
     });
   });
 });