Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-1812] Inclusive language updates #1125

Merged
merged 1 commit into from
Sep 3, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ Parameters:

- **domain {REQUIRED, string}**: Your Auth0 account domain such as `'example.auth0.com'` or `'example.eu.auth0.com'`.
- **clientID {REQUIRED, string}**: The Client ID found on your Application settings page.
- **redirectUri {OPTIONAL, string}**: The URL where Auth0 will call back to with the result of a successful or failed authentication. It must be whitelisted in the "Allowed Callback URLs" in your Auth0 Application's settings.
- **redirectUri {OPTIONAL, string}**: The URL where Auth0 will call back to with the result of a successful or failed authentication. It must be added to the "Allowed Callback URLs" in your Auth0 Application's settings.
- **scope {OPTIONAL, string}**: The default scope used for all authorization requests.
- **audience {OPTIONAL, string}**: The default audience, used if requesting access to an API.
- **responseType {OPTIONAL, string}**: Response type for all authentication requests. It can be any space separated list of the values `code`, `token`, `id_token`. **If you don't provide a global `responseType`, you will have to provide a `responseType` for each method that you use**.
Expand Down
2 changes: 1 addition & 1 deletion src/helper/parameters-whitelist.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// For future reference:,
// The only parameters that should be whitelisted are parameters
// The only parameters that should be allowed are parameters
// defined by the specification, or existing parameters that we
// need for compatibility

Expand Down
2 changes: 1 addition & 1 deletion test/authentication/authentication.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ describe('auth0.authentication', function() {
);
});

it('should return a url using using whitelisted authorization parameter device', function() {
it('should return a url using only the allowed authorization parameter device', function() {
var url = this.auth0.buildAuthorizeUrl({
responseType: 'token',
redirectUri: 'http://anotherpage.com/callback2',
Expand Down
2 changes: 1 addition & 1 deletion test/authentication/ro.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ describe('auth0.authentication', function() {
);
});

it('should exclude parameters not in whitelist', function(done) {
it('should exclude parameters that are not allowed', function(done) {
sinon.stub(request, 'post').callsFake(function(url) {
expect(url).to.be('https://me.auth0.com/oauth/ro');
return new RequestMock({
Expand Down
8 changes: 4 additions & 4 deletions test/helper/object.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -347,8 +347,8 @@ describe('helpers', function() {
});
});

describe('blacklist', function() {
it('should return all the attributes not blacklisted', function() {
describe('the disallow list', function() {
it('should return all the attributes that are allowed to be used', function() {
var object = {
attr1: 'attribute_1',
attr2: 'attribute_2',
Expand Down Expand Up @@ -416,7 +416,7 @@ describe('helpers', function() {
});
});

it('should change the casing to all the attributes that are not blacklisted', function() {
it('should change the casing to all the allowed attributes', function() {
var object = {
attrName1: 'attribute_1',
attrName22: 'attribute_2',
Expand Down Expand Up @@ -482,7 +482,7 @@ describe('helpers', function() {
expect(newObject).to.eql('some random string');
});

it('should change the casing to all the attributes that are not blacklisted', function() {
it('should change the casing to all the allowed attributes', function() {
var object = {
attr_name_1: 'attribute_1',
attr_name_22: 'attribute_2',
Expand Down
2 changes: 1 addition & 1 deletion test/web-auth/popup.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ describe('auth0.WebAuth.popup', function() {
popupOptions: {
height: 300,
width: 250,
extra: 'blacklisted'
extra: 'disallowed'
}
},
function(err, data) {
Expand Down