Make state expiration configurable #1217
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently, the cookie expiration for state is pinned to 30 minutes (that PR here). My company has a business use case to make that longer (probably 1-2 hours), however, I could see a business use case to keep that shorter than 30 minutes.
This change will make this value configurable through
WebAuth
, as a passed in option.If this option is not passed in, current functionality is retained at 30 minutes.
Changes
WebAuth
accepts a new param on options.stateExpiration
- number of minutes for the state to expire in (please provide any name suggestions if as coded could be more explicit)TransactionManager
TransactionManager
accepts the same optionTesting
TransactionManager
with astateExpiration
with a value other than30
generateTransaction
, and see the cookie be set to expire in the given timeframeChecklist