Fix device parameter not being whitelisted for authorization #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 25.17% (diff: 100%)@@ master #312 diff @@
==========================================
Files 30 30
Lines 1025 1025
Methods 173 173
Messages 0 0
Branches 163 163
==========================================
Hits 258 258
Misses 767 767
Partials 0 0
|
glena
approved these changes
Jan 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://auth0.com/docs/tokens/refresh-token when issuing a refresh token it is now mandatory to specify a device parameter with any arbitrary value, this PR adds it to the whitelisted authorization parameters.
Currently our regular web application does not recognize the device parameter and keeps failing as a result, the call into auth0.js is being made from here.