Adding access_token validation for RS256 id_token's #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisrudge
force-pushed
the
feature-validate-at-token
branch
from
737b28c
to
45b35d0
Compare
luisrudge
force-pushed
the
feature-validate-at-token
branch
from
45b35d0
to
79d797e
Compare
lbalmaceda
reviewed
Mar 22, 2018
| @@ -5,11 +5,11 @@ function buildResponse(error, description) { | |||
| }; | |||
| } | |||
|
|
|||
| function invalidJwt(description) { | |||
| function invalidToken(description) { | |||
There was a problem hiding this comment.
can this be considered a breaking change?
There was a problem hiding this comment.
nope. not a public method. just used internally.
| @@ -307,6 +317,75 @@ describe('auth0.WebAuth', function() { | |||
| } | |||
| ); // eslint-disable-line | |||
| }); | |||
| it('should return the id_token payload when there is no access_token', function(done) { | |||
There was a problem hiding this comment.
shouldn't the payload also be returned when there's a VALID access token? That's the missing test case IMO, even if it's 95% similar to this
lbalmaceda
reviewed
Mar 22, 2018
test/web-auth/web-auth.test.js
Outdated
| } | ||
| ); // eslint-disable-line | ||
| }); | ||
| it('should return the id_token payload when there is an access_token', function(done) { |
There was a problem hiding this comment.
when there is a valid access_token
| } | ||
| ); // eslint-disable-line | ||
| }); | ||
| it('should validate an access_token when available', function(done) { |
There was a problem hiding this comment.
I don't know if you are using the same convention somewhere, but I'd say:
should throw a token validation error when the access_token is available but not valid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.