Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

options is optional in WebAuth.prototype.authorize #789

Merged
merged 3 commits into from
Jul 10, 2018
Merged

options is optional in WebAuth.prototype.authorize #789

merged 3 commits into from
Jul 10, 2018

Commits on Jul 6, 2018

  1. options is optional in WebAuth.prototype.authorize 

    In your tutorials, `authorize` is called without any arguments ([example](https://auth0.com/docs/quickstart/spa/jquery/01-login#create-an-authentication-service)).

Consequently, `options` should be marked as optional in the JsDoc (i.e. `[options]`), otherwise IDEs might warn that its invocations require 1 argument.
    @behrangsa
    behrangsa authored Jul 6, 2018
    Configuration menu
    Copy the full SHA
    34e6fc0 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2018

  1. Marked more optional options params as optional in JsDocs.

    @behrangsa
    behrangsa committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    3505992 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into master

    @luisrudge
    luisrudge authored Jul 10, 2018
    Configuration menu
    Copy the full SHA
    2c84c86 View commit details
    Browse the repository at this point in the history